encodeURIs to make sure paths with spaces can be linked in output window (#4394)

Author: gcampbell-msft

src/drivers/cmakeDriver.ts

@@ -562,15 +562,15 @@ export abstract class CMakeDriver implements vscode.Disposable {
         const cache = this.cachePath;
         const cmake_files = this.config.deleteBuildDirOnCleanConfigure ? build_dir : path.join(build_dir, 'CMakeFiles');
         if (await fs.exists(cache)) {
-            log.info(localize('removing', 'Removing {0}', cache));
+            log.info(localize('removing', 'Removing {0}', encodeURI(cache)));
             try {
                 await fs.unlink(cache);
             } catch {
                 log.error(localize('unlink.failed', 'Failed to remove cache file {0}', this.cachePath));
             }
         }
         if (await fs.exists(cmake_files)) {
-            log.info(localize('removing', 'Removing {0}', cmake_files));
+            log.info(localize('removing', 'Removing {0}', encodeURI(cmake_files)));
             await fs.rmdir(cmake_files);
         }
     }

src/drivers/cmakeFileApiDriver.ts

@@ -221,8 +221,8 @@ export class CMakeFileApiDriver extends CMakeDriver {
             }
         }
         // -S and -B were introduced in CMake 3.13 and this driver assumes CMake >= 3.15
-        args.push(`-S${util.lightNormalizePath(this.sourceDir)}`);
-        args.push(`-B${util.lightNormalizePath(binaryDir)}`);
+        args.push("-S", `${encodeURI(util.lightNormalizePath(this.sourceDir))}`);
+        args.push("-B", `${encodeURI(util.lightNormalizePath(binaryDir))}`);
 
         if (!has_gen) {
             const generator = (configurePreset) ? {

src/presets/preset.ts

@@ -2255,10 +2255,10 @@ export function configureArgs(preset: ConfigurePreset): string[] {
     }
 
     if (preset.toolchainFile) {
-        result.push(`-DCMAKE_TOOLCHAIN_FILE=${preset.toolchainFile}`);
+        result.push(`-DCMAKE_TOOLCHAIN_FILE=${encodeURI(preset.toolchainFile)}`);
     }
     if (preset.installDir) {
-        result.push(`-DCMAKE_INSTALL_PREFIX=${preset.installDir}`);
+        result.push(`-DCMAKE_INSTALL_PREFIX=${encodeURI(preset.installDir)}`);
     }
 
     // Warnings