Small string updates (#4363)

* fix for 4319

* fix for 4317

* fix for 4312

* changelog updates

Author: gcampbell-msft

CHANGELOG.md

@@ -15,6 +15,7 @@ Bug Fixes:
 - Fix bug that makes `Configure Task` lists only first folder in workspace. [#3232](https//github.com/microsoft/vscode-cmake-tools/issues/3232)
 - Fix displaying "Go to Test" in the Test Explorer when the DEF_SOURCE_LINE property is set, but there is no backtrace information present. [4321](https://github.com/microsoft/vscode-cmake-tools/pull/4321) [@rjaegers](https://github.com/rjaegers)
 - Fix gnuld error parsing false positive on make errors, false negative due to trailing \r, and false parsing of new "multiple definitions" error [#2864](https://github.com/microsoft/vscode-cmake-tools/issues/2864) [@0xemgy](https://github.com/0xemgy)
+- Fixes for small bug string bugs. [#4319](https://github.com/microsoft/vscode-cmake-tools/issues/4319), [#4317](https://github.com/microsoft/vscode-cmake-tools/issues/4317), [#4312](https://github.com/microsoft/vscode-cmake-tools/issues/4312)
 
 ## 1.20.53
 

src/presets/presetsController.ts

@@ -2,6 +2,7 @@ import * as chokidar from 'chokidar';
 import * as path from 'path';
 import * as vscode from 'vscode';
 import * as nls from 'vscode-nls';
+import * as lodash from "lodash";
 
 import { CMakeProject, ConfigureTrigger, ConfigureType } from '@cmt/cmakeProject';
 import * as logging from '@cmt/logging';
@@ -201,7 +202,7 @@ export class PresetsController implements vscode.Disposable {
         }, {
             name: SpecialOptions.Custom,
             label: localize('custom.config.preset', 'Custom'),
-            description: localize('description.custom.config.preset', 'Add an custom configure preset')
+            description: localize('description.custom.config.preset', 'Add a custom configure preset')
         }, {
             name: SpecialOptions.CreateFromCompilers,
             label: localize('create.from.compilers', 'Create from Compilers'),
@@ -463,7 +464,7 @@ export class PresetsController implements vscode.Disposable {
         items.push({
             name: SpecialOptions.Custom,
             label: localize('custom.build.preset', 'Custom'),
-            description: localize('description.custom.build.preset', 'Add an custom build preset')
+            description: localize('description.custom.build.preset', 'Add a custom build preset')
         });
 
         const chosenItem = await vscode.window.showQuickPick(items,
@@ -540,7 +541,7 @@ export class PresetsController implements vscode.Disposable {
         items.push({
             name: SpecialOptions.Custom,
             label: localize('custom.test.preset', 'Custom'),
-            description: localize('description.custom.test.preset', 'Add an custom test preset')
+            description: localize('description.custom.test.preset', 'Add a custom test preset')
         });
 
         const chosenItem = await vscode.window.showQuickPick(items,
@@ -698,7 +699,7 @@ export class PresetsController implements vscode.Disposable {
         items.push({
             name: SpecialOptions.Custom,
             label: localize('custom.workflow.preset', 'Custom'),
-            description: localize('description.custom.workflow.preset', 'Add an custom workflow preset')
+            description: localize('description.custom.workflow.preset', 'Add a custom workflow preset')
         });
 
         const chosenItem = await vscode.window.showQuickPick(items,
@@ -1411,7 +1412,7 @@ export class PresetsController implements vscode.Disposable {
 
         preset.expandConfigurePresetForPresets(this.folderPath, 'workflow');
 
-        const allPresets = await this.getAllWorkflowPresets();
+        const allPresets = lodash.cloneDeep(await this.getAllWorkflowPresets());
         allPresets.push(preset.defaultWorkflowPreset);
 
         log.debug(localize('start.selection.of.workflow.presets', 'Start selection of workflow presets. Found {0} presets.', allPresets.length));

src/presets/presetsParser.ts

@@ -139,7 +139,7 @@ export class PresetsParser {
         log.info(
             localize(
                 "validating.presets.file",
-                'Reading and validating the presets "file {0}"',
+                'Reading and validating the presets file "{0}"',
                 file
             )
         );