Remove IntentParams and intent:true (#534)

Took a long time, this started as a PR on the old vscode-copilot repo

Author: roblourens

src/extension/conversation/vscode-node/languageModelAccess.ts

@@ -375,7 +375,7 @@ export class CopilotLanguageModelWrapper extends Disposable {
 			{ type: 'function', function: { name: _options.tools[0].name } } :
 			undefined;
 
-		const result = await endpoint.makeChatRequest('copilotLanguageModelWrapper', messages, callback, token, ChatLocation.Other, { extensionId }, options, true, telemetryProperties, { intent: true });
+		const result = await endpoint.makeChatRequest('copilotLanguageModelWrapper', messages, callback, token, ChatLocation.Other, { extensionId }, options, true, telemetryProperties);
 
 		if (result.type !== ChatFetchResponseType.Success) {
 			if (result.type === ChatFetchResponseType.ExtensionBlocked) {

src/extension/mcp/vscode-node/mcpToolCallingLoop.tsx

@@ -92,7 +92,6 @@ export class McpToolCallingLoop extends ToolCallingLoop<IMcpToolCallingLoopOptio
 				...opts.requestOptions,
 				temperature: 0
 			},
-			intentParams: { intent: true }
 		}, token);
 	}
 }

src/extension/prompt/node/chatMLFetcher.ts

@@ -226,7 +226,6 @@ export class ChatMLFetcherImpl extends AbstractChatMLFetcher {
 									requestOptions,
 									userInitiatedRequest: false, // do not mark the retry as user initiated
 									telemetryProperties: { ...telemetryProperties, retryAfterFilterCategory: result.category ?? 'uncategorized' },
-									intentParams: opts.intentParams,
 									isFilterRetry: true,
 								}, token);
 

src/extension/prompt/node/codebaseToolCalling.ts

@@ -88,7 +88,6 @@ export class CodebaseToolCallingLoop extends ToolCallingLoop<ICodebaseToolCallin
 				messageId: randomUUID(), // @TODO@joyceerhl
 				messageSource: CodebaseToolCallingLoop.ID
 			},
-			{ intent: true }
 		);
 	}
 }

src/extension/prompt/node/defaultIntentRequestHandler.ts

@@ -687,7 +687,6 @@ class DefaultToolCallingLoop extends ToolCallingLoop<IDefaultToolLoopOptions> {
 				conversationId: this.options.conversation.sessionId,
 				messageSource: this.options.intent?.id && this.options.intent.id !== UnknownIntent.ID ? `${messageSourcePrefix}.${this.options.intent.id}` : `${messageSourcePrefix}.user`,
 			},
-			intentParams: { intent: true }
 		}, token);
 	}
 

src/extension/workspaceSemanticSearch/node/semanticSearchTextSearchProvider.ts

@@ -232,7 +232,6 @@ export class SemanticSearchTextSearchProvider implements vscode.AITextSearchProv
 						messageId: generateUuid(),
 						messageSource: 'search.workspace'
 					},
-					{ intent: true }
 				);
 				SemanticSearchTextSearchProvider.feedBackTelemetry.llmFilteringDuration = Date.now() - llmFilteringDuration;
 				searchResult = fetchResult.type === 'success' ? fetchResult.value : (fetchResult.type === 'length' ? fetchResult.truncatedValue : '');
@@ -481,7 +480,6 @@ export class SemanticSearchTextSearchProvider implements vscode.AITextSearchProv
 					messageId: generateUuid(),
 					messageSource: 'search.keywords'
 				},
-				{ intent: true }
 			);
 			const keywordResult = fetchResult.type === 'success' ? fetchResult.value : (fetchResult.type === 'length' ? fetchResult.truncatedValue : '');
 			const usedResults = [];

src/platform/chat/common/chatMLFetcher.ts

@@ -11,15 +11,6 @@ import { FinishedCallback, IResponseDelta, OptionalChatRequestParams } from '../
 import { IChatEndpoint, IMakeChatRequestOptions } from '../../networking/common/networking';
 import { ChatResponse, ChatResponses } from './commonTypes';
 
-export interface IntentParams {
-
-	/** Copilot-only: whether to run intent classifier for off-topic detection */
-	intent?: boolean;
-
-	/** Copilot-only: threshold for intent classifier */
-	intent_threshold?: number;
-}
-
 export interface Source {
 	readonly extensionId?: string;
 }
@@ -43,19 +34,6 @@ export interface IChatMLFetcher {
 
 	readonly onDidMakeChatMLRequest: Event<{ readonly model: string; readonly source?: Source; readonly tokenCount?: number }>;
 
-	/**
-	 * @param debugName A helpful name for the request, shown in logs and used in telemetry if telemetryProperties.messageSource isn't set. Using a single camelCase word is advised.
-	 * @param messages The list of messages to send to the model
-	 * @param finishedCb A callback that streams response content
-	 * @param token A cancel token
-	 * @param location The location of the feature making this request
-	 * @param endpoint The chat model info
-	 * @param source The participant/extension making this request, if applicable
-	 * @param requestOptions To override the default request options
-	 * @param userInitiatedRequest Whether or not the request is the user's or some background / auxillary request. Used for billing.
-	 * @param telemetryProperties messageSource/messageId are included in telemetry, optional, defaults to debugName
-	 * @param intentParams { intent: true } enables the offtopic classifier
-	 */
 	fetchOne(options: IFetchMLOptions, token: CancellationToken): Promise<ChatResponse>;
 
 	/**

src/platform/chat/common/responses.ts

@@ -5,7 +5,7 @@
 
 import { Raw } from '@vscode/prompt-tsx';
 import { OptionalChatRequestParams } from '../../networking/common/fetch';
-import { IntentParams, Source } from './chatMLFetcher';
+import { Source } from './chatMLFetcher';
 import { ChatLocation } from './commonTypes';
 
 export interface IRichChatRequestOptions {
@@ -17,6 +17,4 @@ export interface IRichChatRequestOptions {
 	requestOptions?: Omit<OptionalChatRequestParams, 'n'>;
 	/** Whether the request was user-initiated (applicable to CAPI requests) */
 	userInitiatedRequest?: boolean;
-	/** Intent parameters (applicable to CAPI requests) */
-	intentParams?: IntentParams;
 }

src/platform/endpoint/common/autoChatEndpoint.ts

@@ -8,7 +8,7 @@ import { ChatMessage } from '@vscode/prompt-tsx/dist/base/output/rawTypes';
 import type { CancellationToken } from 'vscode';
 import { ITokenizer, TokenizerType } from '../../../util/common/tokenizer';
 import { AsyncIterableObject } from '../../../util/vs/base/common/async';
-import { IntentParams, Source } from '../../chat/common/chatMLFetcher';
+import { Source } from '../../chat/common/chatMLFetcher';
 import { ChatLocation, ChatResponse } from '../../chat/common/commonTypes';
 import { IEnvService } from '../../env/common/envService';
 import { ILogService } from '../../log/common/logService';
@@ -79,7 +79,7 @@ export class AutoChatEndpoint implements IChatEndpoint {
 		return this._wrappedEndpoint.makeChatRequest2(options, token);
 	}
 
-	async makeChatRequest(debugName: string, messages: ChatMessage[], finishedCb: FinishedCallback | undefined, token: CancellationToken, location: ChatLocation, source?: Source, requestOptions?: Omit<OptionalChatRequestParams, 'n'>, userInitiatedRequest?: boolean, telemetryProperties?: TelemetryProperties, intentParams?: IntentParams): Promise<ChatResponse> {
+	async makeChatRequest(debugName: string, messages: ChatMessage[], finishedCb: FinishedCallback | undefined, token: CancellationToken, location: ChatLocation, source?: Source, requestOptions?: Omit<OptionalChatRequestParams, 'n'>, userInitiatedRequest?: boolean, telemetryProperties?: TelemetryProperties): Promise<ChatResponse> {
 		return this.makeChatRequest2({
 			debugName,
 			messages,
@@ -89,7 +89,6 @@ export class AutoChatEndpoint implements IChatEndpoint {
 			requestOptions,
 			userInitiatedRequest,
 			telemetryProperties,
-			intentParams
 		}, token);
 	}
 }

src/platform/endpoint/node/chatEndpoint.ts

@@ -12,7 +12,7 @@ import { deepClone, mixin } from '../../../util/vs/base/common/objects';
 import { generateUuid } from '../../../util/vs/base/common/uuid';
 import { IInstantiationService } from '../../../util/vs/platform/instantiation/common/instantiation';
 import { IAuthenticationService } from '../../authentication/common/authentication';
-import { IChatMLFetcher, IntentParams, Source } from '../../chat/common/chatMLFetcher';
+import { IChatMLFetcher, Source } from '../../chat/common/chatMLFetcher';
 import { ChatLocation, ChatResponse } from '../../chat/common/commonTypes';
 import { getTextPart } from '../../chat/common/globalStringUtils';
 import { CHAT_MODEL, ConfigKey, IConfigurationService } from '../../configuration/common/configurationService';
@@ -318,7 +318,6 @@ export class ChatEndpoint implements IChatEndpoint {
 		requestOptions?: Omit<OptionalChatRequestParams, 'n'>,
 		userInitiatedRequest?: boolean,
 		telemetryProperties?: TelemetryProperties,
-		intentParams?: IntentParams
 	): Promise<ChatResponse> {
 		return this.makeChatRequest2({
 			debugName,
@@ -329,7 +328,6 @@ export class ChatEndpoint implements IChatEndpoint {
 			requestOptions,
 			userInitiatedRequest,
 			telemetryProperties,
-			intentParams
 		}, token);
 	}