Skip to content

Commit 19f692f

Browse files
authored
Disable old automatic re-indexing flow (#1190)
This is been disabled by an experiment for a while now. We've found that we generally don't see much benefit from doing this work eagerly but that it does cause a significant server load
1 parent f85c62b commit 19f692f

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/platform/workspaceChunkSearch/node/embeddingsChunkSearch.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -331,12 +331,10 @@ export class EmbeddingsChunkSearch extends Disposable implements IWorkspaceChunk
331331
}
332332
};
333333

334-
this._reindexDisposables.add(this._workspaceIndex.onDidCreateFiles(async uris => {
334+
this._reindexDisposables.add(this._workspaceIndex.onDidCreateFiles(async _uris => {
335335
updateIndexState();
336-
this.tryTriggerReindexing(uris, new TelemetryCorrelationId('EmbeddingsChunkSearch::onDidCreateFiles'));
337336
}));
338337

339-
this._reindexDisposables.add(this._workspaceIndex.onDidChangeFiles(uris => this.tryTriggerReindexing(uris, new TelemetryCorrelationId('EmbeddingsChunkSearch::onDidChangeFiles'))));
340338
this._reindexDisposables.add(this._workspaceIndex.onDidDeleteFiles(uris => {
341339
for (const uri of uris) {
342340
this._reindexRequests.get(uri)?.dispose();
@@ -388,18 +386,17 @@ export class EmbeddingsChunkSearch extends Disposable implements IWorkspaceChunk
388386
}
389387
}
390388

391-
public tryTriggerReindexing(uris: readonly URI[], telemetryInfo: TelemetryCorrelationId, immediately = false): void {
389+
public tryTriggerReindexing(uris: readonly URI[], telemetryInfo: TelemetryCorrelationId): void {
392390
if (this._state === LocalEmbeddingsIndexStatus.TooManyFilesForAnyIndexing
393391
|| this._state === LocalEmbeddingsIndexStatus.TooManyFilesForAutomaticIndexing
394392
) {
395393
return;
396394
}
397395

398-
const defaultDelay = this._experimentationService.getTreatmentVariable<number>('workspace.embeddingIndex.automaticReindexingDelay') ?? 60000;
399396
for (const uri of uris) {
400397
let delayer = this._reindexRequests.get(uri);
401398
if (!delayer) {
402-
delayer = new Delayer<void>(defaultDelay);
399+
delayer = new Delayer<void>(0);
403400
this._reindexRequests.set(uri, delayer);
404401
}
405402

@@ -413,7 +410,7 @@ export class EmbeddingsChunkSearch extends Disposable implements IWorkspaceChunk
413410
}
414411

415412
return this._embeddingsIndex.triggerIndexingOfFile(uri, telemetryInfo.addCaller('EmbeddingChunkSearch::tryTriggerReindexing'), this._disposeCts.token);
416-
}, immediately ? 0 : defaultDelay);
413+
}, 0);
417414
}
418415
}
419416
}

0 commit comments

Comments
 (0)