fix #256516 (#284)

Author: meganrogge

src/extension/tools/node/newWorkspace/createAndRunTaskTool.tsx

@@ -18,6 +18,7 @@ import { joinPath } from '../../../../util/vs/base/common/resources';
 import { LanguageModelTextPart, LanguageModelToolResult, MarkdownString, Uri } from '../../../../vscodeTypes';
 import { ToolName } from '../../common/toolNames';
 import { ToolRegistry } from '../../common/toolsRegistry';
+import { getTaskRepresentation } from '../toolUtils.task';
 
 interface ICreateAndRunTaskToolInput {
 	workspaceFolder: string;
@@ -107,6 +108,23 @@ export class CreateAndRunTaskTool implements vscode.LanguageModelTool<ICreateAnd
 				confirmationMessages: undefined
 			};
 		}
+		if (this.tasksService.hasTask(workspaceFolder, task)) {
+			const position = workspaceFolder && task && await this.tasksService.getTaskConfigPosition(workspaceFolder, task);
+			const link = (s: string) => position ? `[${s}](${position.uri.toString()}#${position.range.startLineNumber}-${position.range.endLineNumber})` : s;
+			const trustedMark = (value: string) => {
+				const s = new MarkdownString(value);
+				s.isTrusted = true;
+				return s;
+			};
+
+			return {
+				invocationMessage: trustedMark(l10n.t`Running ${link(task.label)}`),
+				pastTenseMessage: trustedMark(task?.isBackground ? l10n.t`Started ${link(task.label)}` : l10n.t`Ran ${link(task.label)}`),
+				confirmationMessages: task && task.group !== 'build'
+					? { title: l10n.t`Allow task run?`, message: trustedMark(l10n.t`Allow Copilot to run the \`${task.type}\` task ${link(`\`${getTaskRepresentation(task)}\``)}?`) }
+					: undefined
+			};
+		}
 		try {
 			await this.fileSystemService.stat(Uri.parse(tasksFilePath));
 			return {
@@ -125,7 +143,6 @@ export class CreateAndRunTaskTool implements vscode.LanguageModelTool<ICreateAnd
 					)
 				}
 			};
-
 		}
 	}
 }

src/extension/tools/node/runTaskTool.tsx

@@ -18,6 +18,7 @@ import { CancellationToken } from '../../../util/vs/base/common/cancellation';
 import { ChatLocation, LanguageModelTextPart, LanguageModelToolResult, MarkdownString } from '../../../vscodeTypes';
 import { ToolName } from '../common/toolNames';
 import { ToolRegistry } from '../common/toolsRegistry';
+import { getTaskRepresentation } from './toolUtils.task';
 
 interface IRunTaskToolInput {
 	id: string;
@@ -173,22 +174,11 @@ class RunTaskTool implements vscode.LanguageModelTool<IRunTaskToolInput> {
 			invocationMessage: trustedMark(l10n.t`Running ${taskLabel ?? link(options.input.id)}`),
 			pastTenseMessage: trustedMark(task?.isBackground ? l10n.t`Started ${link(taskLabel ?? options.input.id)}` : l10n.t`Ran ${link(taskLabel ?? options.input.id)}`),
 			confirmationMessages: task && task.group !== 'build'
-				? { title: l10n.t`Allow task run?`, message: trustedMark(l10n.t`Allow Copilot to run the \`${task.type}\` task ${link(`\`${this.getTaskRepresentation(task)}\``)}?`) }
+				? { title: l10n.t`Allow task run?`, message: trustedMark(l10n.t`Allow Copilot to run the \`${task.type}\` task ${link(`\`${getTaskRepresentation(task)}\``)}?`) }
 				: undefined
 		};
 	}
 
-	private getTaskRepresentation(task: vscode.TaskDefinition): string {
-		if ('label' in task) {
-			return task.label;
-		} else if ('script' in task) {
-			return task.script;
-		} else if ('command' in task) {
-			return task.command;
-		}
-		return '';
-	}
-
 	private getTaskDefinition(input: IRunTaskToolInput) {
 		const idx = input.id.indexOf(': ');
 		const taskType = input.id.substring(0, idx);

src/extension/tools/node/toolUtils.task.ts

@@ -0,0 +1,16 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+import type * as vscode from 'vscode';
+
+export function getTaskRepresentation(task: vscode.TaskDefinition): string {
+	if ('label' in task) {
+		return task.label;
+	} else if ('script' in task) {
+		return task.script;
+	} else if ('command' in task) {
+		return task.command;
+	}
+	return '';
+}