fix: enable apply patch for more models (#389)

* fix: enable apply patch for more models

* fix: add `modelPrefersJsonNotebookRepresentation`

Author: karthiknadig

src/extension/intents/node/agentIntent.ts

@@ -62,7 +62,7 @@ const getTools = (instaService: IInstantiationService, request: vscode.ChatReque
 		const allowTools: Record<string, boolean> = {};
 		allowTools[ToolName.EditFile] = true;
 		allowTools[ToolName.ReplaceString] = modelSupportsReplaceString(model) || !!(model.family.includes('gemini') && configurationService.getExperimentBasedConfig(ConfigKey.Internal.GeminiReplaceString, experimentationService));
-		allowTools[ToolName.ApplyPatch] = modelSupportsApplyPatch(model) && !!toolsService.getTool(ToolName.ApplyPatch);
+		allowTools[ToolName.ApplyPatch] = await modelSupportsApplyPatch(model) && !!toolsService.getTool(ToolName.ApplyPatch);
 
 		if (modelCanUseReplaceStringExclusively(model)) {
 			allowTools[ToolName.ReplaceString] = true;

src/platform/endpoint/common/chatModelCapabilities.ts

@@ -6,6 +6,16 @@
 import type { LanguageModelChat } from 'vscode';
 import type { IChatEndpoint } from '../../networking/common/networking';
 
+
+function getSha256Hash(text: string): Promise<string> {
+	const encoder = new TextEncoder();
+	const data = encoder.encode(text);
+	return crypto.subtle.digest('SHA-256', data).then(hashBuffer => {
+		const hashArray = Array.from(new Uint8Array(hashBuffer));
+		return hashArray.map(b => b.toString(16).padStart(2, '0')).join('');
+	});
+}
+
 /**
  * Returns whether the instructions should be given in a user message instead
  * of a system message when talking to the model.
@@ -25,7 +35,17 @@ export function modelPrefersInstructionsAfterHistory(modelFamily: string) {
 /**
  * Model supports apply_patch as an edit tool.
  */
-export function modelSupportsApplyPatch(model: LanguageModelChat | IChatEndpoint): boolean {
+export async function modelSupportsApplyPatch(model: LanguageModelChat | IChatEndpoint): Promise<boolean> {
+	if (model.family === 'gpt-4.1' || model.family === 'o4-mini') {
+		return true;
+	}
+	return await getSha256Hash(model.family) === 'a99dd17dfee04155d863268596b7f6dd36d0a6531cd326348dbe7416142a21a3';
+}
+
+/**
+ * Model prefers JSON notebook representation.
+ */
+export function modelPrefersJsonNotebookRepresentation(model: LanguageModelChat | IChatEndpoint): boolean {
 	return model.family === 'gpt-4.1' || model.family === 'o4-mini';
 }
 

src/platform/notebook/common/alternativeContent.ts

@@ -8,13 +8,13 @@ import { findCell } from '../../../util/common/notebooks';
 import { createServiceIdentifier } from '../../../util/common/services';
 import { Range } from '../../../vscodeTypes';
 import { ConfigKey, IConfigurationService } from '../../configuration/common/configurationService';
+import { modelPrefersJsonNotebookRepresentation } from '../../endpoint/common/chatModelCapabilities';
+import { IChatEndpoint } from '../../networking/common/networking';
+import { IExperimentationService } from '../../telemetry/common/nullExperimentationService';
 import { BaseAlternativeNotebookContentProvider } from './alternativeContentProvider';
 import { AlternativeJsonNotebookContentProvider, isJsonContent } from './alternativeContentProvider.json';
 import { AlternativeTextNotebookContentProvider } from './alternativeContentProvider.text';
 import { AlternativeXmlNotebookContentProvider, isXmlContent } from './alternativeContentProvider.xml';
-import { IExperimentationService } from '../../telemetry/common/nullExperimentationService';
-import { IChatEndpoint } from '../../networking/common/networking';
-import { modelSupportsApplyPatch } from '../../endpoint/common/chatModelCapabilities';
 
 export type AlternativeContentFormat = 'xml' | 'text' | 'json';
 
@@ -63,7 +63,7 @@ export class AlternativeNotebookContentService implements IAlternativeNotebookCo
 	}
 	getFormat(options: LanguageModelChat | IChatEndpoint | undefined): AlternativeContentFormat {
 		// GPT 4.1 supports apply_patch, such models work best with JSON format (doesn't have great support for XML yet, thats being worked on).
-		if (options && modelSupportsApplyPatch(options)) {
+		if (options && modelPrefersJsonNotebookRepresentation(options)) {
 			return 'json';
 		}