Detect subshell in terminal inline chat (#249)

* Detect subshell in terminal inline chat

* Remove unnecessary code

* clean up 2

* More clean up

* stick to default shell type dep on platform if cant detect shell type

* more clean up

* Change name for authLearnMore proposed API

Author: anthonykim1

package-lock.json

@@ -3765,7 +3765,7 @@
 		"@types/source-map-support": "^0.5.10",
 		"@types/tar": "^6.1.13",
 		"@types/vinyl": "^2.0.12",
-		"@types/vscode": "^1.96.0",
+		"@types/vscode": "^1.102.0",
 		"@typescript-eslint/eslint-plugin": "^8.35.0",
 		"@typescript-eslint/parser": "^8.32.0",
 		"@typescript-eslint/typescript-estree": "^8.26.1",

package.json

@@ -7,10 +7,10 @@ declare module 'vscode' {
 
 	// https://github.com/microsoft/vscode/issues/206587
 
-	export interface AuthenticationForceNewSessionOptions {
+	export interface AuthenticationGetSessionPresentationOptions {
 		/**
 		 * An optional Uri to open in the browser to learn more about this authentication request.
 		 */
 		learnMore?: Uri;
 	}
-}
+}

src/extension/vscode.proposed.authLearnMore.d.ts

@@ -57,6 +57,12 @@ export function getActiveTerminalSelection(): string {
 let lastDetectedShellType: string | undefined;
 export function getActiveTerminalShellType(): string {
 	const activeTerminal = window.activeTerminal;
+
+	// Prefer the state object as it's the most reliable
+	if (activeTerminal?.state.shell) {
+		return activeTerminal.state.shell;
+	}
+
 	if (activeTerminal && 'shellPath' in activeTerminal.creationOptions) {
 		const shellPath = activeTerminal.creationOptions.shellPath;
 		if (shellPath) {
@@ -93,10 +99,7 @@ export function getActiveTerminalShellType(): string {
 
 	// Fall back to bash or PowerShell, this uses the front end OS so it could give the wrong shell
 	// when remoting from Windows into non-Windows or vice versa.
-	if (platform === 'win32') {
-		return 'powershell';
-	}
-	return 'bash';
+	return platform === 'win32' ? 'powershell' : 'bash';
 }
 
 function appendLimitedWindow<T>(target: T[], data: T) {
@@ -109,6 +112,14 @@ function appendLimitedWindow<T>(target: T[], data: T) {
 
 export function installTerminalBufferListeners(): Disposable[] {
 	return [
+		window.onDidChangeTerminalState(t => {
+			if (window.activeTerminal && t.processId === window.activeTerminal.processId) {
+				const newShellType = t.state.shell;
+				if (newShellType && newShellType !== lastDetectedShellType) {
+					lastDetectedShellType = newShellType;
+				}
+			}
+		}),
 		window.onDidWriteTerminalData(e => {
 			let dataBuffer = terminalBuffers.get(e.terminal);
 			if (!dataBuffer) {

src/platform/terminal/vscode/terminalBufferListener.ts

@@ -844,7 +844,7 @@ class SimulationTerminal extends Disposable implements vscode.Terminal {
 	) {
 		super();
 		this.name = creationOptions.name ?? '';
-		this.state = { isInteractedWith: false };
+		this.state = { isInteractedWith: false, shell: undefined };
 		const cwd = creationOptions.cwd ?? workspace.workspaceFolders[0];
 		if (typeof cwd === 'string') {
 			throw new Error('String cwd not implemented');