no auth - offer sign-in dialog when rate limited (#1124)

Author: bpasero

src/extension/prompt/node/gitCommitMessageGenerator.ts

@@ -15,6 +15,7 @@ import { IInstantiationService } from '../../../util/vs/platform/instantiation/c
 import { PromptRenderer } from '../../prompts/node/base/promptRenderer';
 import { GitCommitMessagePrompt } from '../../prompts/node/git/gitCommitMessagePrompt';
 import { RecentCommitMessages } from '../common/repository';
+import { IAuthenticationService } from '../../../platform/authentication/common/authentication';
 
 type ResponseFormat = 'noTextCodeBlock' | 'oneTextCodeBlock' | 'multipleTextCodeBlocks';
 
@@ -27,6 +28,7 @@ export class GitCommitMessageGenerator {
 		@ITelemetryService private readonly telemetryService: ITelemetryService,
 		@INotificationService private readonly notificationService: INotificationService,
 		@IInteractionService private readonly interactionService: IInteractionService,
+		@IAuthenticationService private readonly authService: IAuthenticationService,
 	) { }
 
 	async generateGitCommitMessage(changes: Diff[], recentCommitMessages: RecentCommitMessages, attemptCount: number, token: CancellationToken): Promise<string | undefined> {
@@ -81,8 +83,8 @@ export class GitCommitMessageGenerator {
 			timeToComplete: Date.now() - startTime
 		});
 
-		if (fetchResult.type === ChatFetchResponseType.QuotaExceeded) {
-			await this.notificationService.showQuotaExceededDialog();
+		if (fetchResult.type === ChatFetchResponseType.QuotaExceeded || (fetchResult.type === ChatFetchResponseType.RateLimited && this.authService.copilotToken?.isNoAuthUser)) {
+			await this.notificationService.showQuotaExceededDialog({ isNoAuthUser: this.authService.copilotToken?.isNoAuthUser ?? false });
 			return undefined;
 		}
 

src/extension/prompt/node/githubPullRequestTitleAndDescriptionGenerator.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { RenderPromptResult } from '@vscode/prompt-tsx';
+import { IAuthenticationService } from '../../../platform/authentication/common/authentication';
 import { ChatFetchResponseType, ChatLocation } from '../../../platform/chat/common/commonTypes';
 import { IConversationOptions } from '../../../platform/chat/common/conversationOptions';
 import { IEndpointProvider } from '../../../platform/endpoint/common/endpointProvider';
@@ -30,6 +31,7 @@ export class GitHubPullRequestTitleAndDescriptionGenerator implements TitleAndDe
 		@IEndpointProvider private readonly endpointProvider: IEndpointProvider,
 		@IInstantiationService private readonly instantiationService: IInstantiationService,
 		@INotificationService private readonly notificationService: INotificationService,
+		@IAuthenticationService private readonly authService: IAuthenticationService,
 	) {
 		this.logService.info('[githubTitleAndDescriptionProvider] Initializing GitHub PR title and description provider provider.');
 	}
@@ -95,8 +97,8 @@ export class GitHubPullRequestTitleAndDescriptionGenerator implements TitleAndDe
 			);
 
 		this.lastContext = { commitMessages, patches };
-		if (fetchResult.type === ChatFetchResponseType.QuotaExceeded) {
-			await this.notificationService.showQuotaExceededDialog();
+		if (fetchResult.type === ChatFetchResponseType.QuotaExceeded || (fetchResult.type === ChatFetchResponseType.RateLimited && this.authService.copilotToken?.isNoAuthUser)) {
+			await this.notificationService.showQuotaExceededDialog({ isNoAuthUser: this.authService.copilotToken?.isNoAuthUser ?? false });
 		}
 
 		if (fetchResult.type !== ChatFetchResponseType.Success) {

src/extension/renameSuggestions/node/renameSuggestionsProvider.ts

@@ -155,8 +155,8 @@ export class RenameSuggestionsProvider implements vscode.NewSymbolNamesProvider
 						);
 						const fetchTime = sw.elapsed();
 
-						if (fetchResult.type === ChatFetchResponseType.QuotaExceeded) {
-							await this._notificationService.showQuotaExceededDialog();
+						if (fetchResult.type === ChatFetchResponseType.QuotaExceeded || (fetchResult.type === ChatFetchResponseType.RateLimited && this._authService.copilotToken?.isNoAuthUser)) {
+							await this._notificationService.showQuotaExceededDialog({ isNoAuthUser: this._authService.copilotToken?.isNoAuthUser ?? false });
 						}
 
 						if (token.isCancellationRequested) {

src/platform/notification/common/notificationService.ts

@@ -35,7 +35,7 @@ export interface INotificationService {
 	showInformationMessage(message: string, ...items: string[]): Promise<string | undefined>;
 	showInformationMessage<T extends string>(message: string, options: MessageOptions, ...items: T[]): Promise<T | undefined>;
 	showWarningMessage(message: string, ...items: string[]): Promise<string | undefined>;
-	showQuotaExceededDialog(): Promise<unknown>;
+	showQuotaExceededDialog(options: { isNoAuthUser: boolean }): Promise<unknown>;
 	withProgress<R>(options: ProgressOptions, task: (progress: Progress<{
 		message?: string;
 		increment?: number;
@@ -56,7 +56,7 @@ export class NullNotificationService implements INotificationService {
 		return Promise.resolve(undefined);
 	}
 
-	showQuotaExceededDialog(): Promise<unknown> {
+	showQuotaExceededDialog(options: { isNoAuthUser: boolean }): Promise<unknown> {
 		return Promise.resolve();
 	}
 

src/platform/notification/vscode/notificationServiceImpl.ts

@@ -31,7 +31,7 @@ export class NotificationService implements INotificationService {
 		return window.showWarningMessage(message, ...items);
 	}
 
-	async showQuotaExceededDialog(): Promise<unknown> {
-		return commands.executeCommand('workbench.action.chat.openQuotaExceededDialog');
+	async showQuotaExceededDialog(options: { isNoAuthUser: boolean }): Promise<unknown> {
+		return commands.executeCommand(options.isNoAuthUser ? 'workbench.action.chat.triggerSetup' : 'workbench.action.chat.openQuotaExceededDialog');
 	}
 }