Add security-sensitive file extensions to workspace indexing exclusion list #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances security by preventing the indexing of sensitive certificate and private key files in the workspace file indexing system. It adds security-related file extensions to the exclusion list to avoid accidentally processing or exposing sensitive cryptographic materials.
- Adds certificate file extensions (pfx, p12, pem, crt, cer) to prevent indexing
- Adds private key extensions (key, priv) to the exclusion list
- Includes Java keystore formats (jks, keystore) and certificate signing requests (csr)
mjbvz
approved these changes
Oct 7, 2025
roblourens
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the list of excluded file extensions in the
workspaceFileIndex.tsfile to improve security and prevent indexing of sensitive files. The change specifically adds several certificate and private key file types to the exclusion list.Security-related exclusions:
pfx,p12,pem,crt,cer,key,priv,jks,keystore,csr) to theEXCLUDE_EXTENSIONSset inworkspaceFileIndex.tsto prevent indexing of security-sensitive files.