rewriteManifest did not actually rewrite package (#1423)

WardenGnaw · web-flow · commit 0b8cdac4a673 · 2018-01-08T17:18:25.000-08:00
diff --git a/Extension/src/main.ts b/Extension/src/main.ts
@@ -434,7 +434,7 @@ function checkDistro(channel: vscode.OutputChannel, platformInfo: PlatformInform
     }
 }
 
-function rewriteManifest(installBlob: InstallBlob): void {
+function rewriteManifest(installBlob: InstallBlob): Promise<void> {
     installBlob.stage = "rewriteManifest";
 
     // Replace activationEvents with the events that the extension should be activated for subsequent sessions.
@@ -459,4 +459,6 @@ function rewriteManifest(installBlob: InstallBlob): void {
         "onCommand:C_Cpp.TakeSurvey",
         "onDebug"
     ];
+
+    return util.writeFileText(util.getPackageJsonPath(), util.getPackageJsonString());
 }

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ function checkDistro(channel: vscode.OutputChannel, platformInfo: PlatformInform`
`434`	`434`	`}`
`435`	`435`	`}`
`436`	`436`
`437`		`-function rewriteManifest(installBlob: InstallBlob): void {`
	`437`	`+function rewriteManifest(installBlob: InstallBlob): Promise<void> {`
`438`	`438`	`installBlob.stage = "rewriteManifest";`
`439`	`439`
`440`	`440`	`// Replace activationEvents with the events that the extension should be activated for subsequent sessions.`
`@@ -459,4 +459,6 @@ function rewriteManifest(installBlob: InstallBlob): void {`
`459`	`459`	`"onCommand:C_Cpp.TakeSurvey",`
`460`	`460`	`"onDebug"`
`461`	`461`	`];`
	`462`	`+`
	`463`	`+ return util.writeFileText(util.getPackageJsonPath(), util.getPackageJsonString());`
`462`	`464`	`}`