Skip to content

Commit 155ed2b

Browse files
fix version filtering (#5175)
1 parent 9b2c568 commit 155ed2b

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Extension/src/main.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,12 @@ function packageMatchesPlatform(pkg: IPackage, info: PlatformInformation): boole
177177
VersionsMatch(pkg, info);
178178
}
179179

180+
function invalidPackageVersion(pkg: IPackage, info: PlatformInformation): boolean {
181+
return PlatformsMatch(pkg, info) &&
182+
(pkg.architectures === undefined || ArchitecturesMatch(pkg, info)) &&
183+
!VersionsMatch(pkg, info);
184+
}
185+
180186
function makeOfflineBinariesExecutable(info: PlatformInformation): Promise<void> {
181187
let promises: Thenable<void>[] = [];
182188
let packages: IPackage[] = util.packageJson["runtimeDependencies"];
@@ -196,7 +202,7 @@ function cleanUpUnusedBinaries(info: PlatformInformation): Promise<void> {
196202

197203
packages.forEach(p => {
198204
if (p.binaries && p.binaries.length > 0 &&
199-
!packageMatchesPlatform(p, info)) {
205+
invalidPackageVersion(p, info)) {
200206
p.binaries.forEach(binary => {
201207
const path: string = util.getExtensionFilePath(binary);
202208
if (fs.existsSync(path)) {

0 commit comments

Comments
 (0)