Switch to Select IntelliSense Configuration (#10771)

* Switch to Select IntelliSense Configuration
* Update version and changelog for 1.15.2

Author: sean-mcmanus

Extension/CHANGELOG.md

@@ -1,5 +1,26 @@
 # C/C++ for Visual Studio Code Changelog
 
+## Version 1.15.2: March 12, 2023
+### Enhancements
+* Add a "Configure IntelliSense" status bar warning. [#10685](https://github.com/microsoft/vscode-cpptools/issues/10685)
+* Update to clang-format/tidy 16. [#10725](https://github.com/microsoft/vscode-cpptools/issues/10725)
+* Move the configuration status bar item out of the language status UI. [#10755](https://github.com/microsoft/vscode-cpptools/issues/10755)
+* Change `Select Default Compiler` to `Select IntelliSense Configuration` with configuration providers and compile commands added. [#10756](https://github.com/microsoft/vscode-cpptools/issues/10756)
+
+### Bug Fixes
+* Support use of `ccache` in `compilerPath` and `compile_commands.json` command lines. [#7616](https://github.com/microsoft/vscode-cpptools/issues/7616)
+* Fix two vcFormat settings being inverted. [#10262](https://github.com/microsoft/vscode-cpptools/issues/10262), [#10263](https://github.com/microsoft/vscode-cpptools/issues/10263)
+* Fix the browse configuration provider cache not getting cleared. [#10692](https://github.com/microsoft/vscode-cpptools/issues/10692)
+* Fix a crash with recursive environment variables on Windows. [#10704](https://github.com/microsoft/vscode-cpptools/issues/10704)
+* Fix `#import` of `.tlb` files failing due to `/Fo` arguments to `cl.exe` not being processed. [#10710](https://github.com/microsoft/vscode-cpptools/issues/10710)
+* Fix `cppbuild` tasks not using the workspace folder as the `cwd` by default. [#10742](https://github.com/microsoft/vscode-cpptools/issues/10742)
+* Fix lots of IntelliSense processes getting launched after a Find/Replace operation (potentially freezing the OS). [#10743](https://github.com/microsoft/vscode-cpptools/issues/10743)
+* Fix workspace folder variable resolution with `clang_format_style`. [#10752](https://github.com/microsoft/vscode-cpptools/issues/10752)
+* For remote attach, use an absolute `/bin/sh` path on Linux. [PR #10765](https://github.com/microsoft/vscode-cpptools/pull/10765)
+* Fix the first registered configuration provider still being automatically used after a second registers. [PR #10772](https://github.com/microsoft/vscode-cpptools/pull/10772)
+* Fix `C_Cpp.default.compilerPath` in the settings UI showing a string editor when it shouldn't. [#10795](https://github.com/microsoft/vscode-cpptools/issues/10795)
+* Fix some issues due to usage of the spread operator not doing a deep copy. [PR #10803](https://github.com/microsoft/vscode-cpptools/pull/10803)
+
 ## Version 1.15.1: March 22, 2023
 ### Bug Fixes
 * Fix crashes with a multiroot workspace. [#10636](https://github.com/microsoft/vscode-cpptools/issues/10636)

Extension/package.json

@@ -2,7 +2,7 @@
   "name": "cpptools",
   "displayName": "C/C++",
   "description": "C/C++ IntelliSense, debugging, and code browsing.",
-  "version": "1.15.1-main",
+  "version": "1.15.2-main",
   "publisher": "ms-vscode",
   "icon": "LanguageCCPP_color_128x.png",
   "readme": "README.md",
@@ -3006,6 +3006,11 @@
         "title": "%c_cpp.command.selectDefaultCompiler.title%",
         "category": "C/C++"
       },
+      {
+        "command": "C_Cpp.SelectIntelliSenseConfiguration",
+        "title": "%c_cpp.command.selectIntelliSenseConfiguration.title%",
+        "category": "C/C++"
+      },
       {
         "command": "C_Cpp.RescanCompilers",
         "title": "%c_cpp.command.rescanCompilers.title%",
@@ -5501,6 +5506,10 @@
           "command": "C_Cpp.referencesViewUngroupByType",
           "when": "cpptools.hasReferencesResults"
         },
+        {
+          "command": "C_Cpp.SelectDefaultCompiler",
+          "when": "never"
+        },
         {
           "command": "C_Cpp.RescanCompilers",
           "when": "never"
@@ -5990,7 +5999,7 @@
     "generateOptionsSchema": "node ./tools/prepublish.js && node ./out/tools/generateOptionsSchema.js",
     "generate-native-strings": "node ./tools/prepublish.js && gulp generate-native-strings",
     "translations-export": "node ./tools/prepublish.js && gulp generate-native-strings && gulp translations-export",
-    "translations-generate": "node ./tools/prepublish.js && gulp translations-generate",
+    "translations-generate": "node ./tools/prepublish.js && set NODE_OPTIONS=--no-experimental-fetch && gulp translations-generate",
     "translations-import": "node ./tools/prepublish.js && gulp translations-import",
     "copy-walkthrough-media": "node ./tools/prepublish.js && gulp copy-walkthrough-media",
     "prepublishjs": "node ./tools/prepublish.js",

Extension/package.nls.json

@@ -11,7 +11,8 @@
     "c_cpp.command.configurationProviderSelect.title": "Change Configuration Provider...",
     "c_cpp.command.configurationEditJSON.title": "Edit Configurations (JSON)",
     "c_cpp.command.configurationEditUI.title": "Edit Configurations (UI)",
-    "c_cpp.command.selectDefaultCompiler.title": "Select Default Compiler",
+    "c_cpp.command.selectDefaultCompiler.title": "Select Default Compiler...",
+    "c_cpp.command.selectIntelliSenseConfiguration.title": "Select IntelliSense Configuration...",
     "c_cpp.command.rescanCompilers.title": "Rescan for Compilers",
     "c_cpp.command.switchHeaderSource.title": "Switch Header/Source",
     "c_cpp.command.enableErrorSquiggles.title": "Enable Error Squiggles",

Extension/src/LanguageServer/Providers/codeActionProvider.ts

@@ -67,8 +67,16 @@ export class CodeActionProvider implements vscode.CodeActionProvider {
             throw new vscode.CancellationError();
         }
 
-        let hasSelectDefaultCompiler: boolean = false;
-        let hasConfigurationCompilerPath: boolean = false;
+        let hasSelectIntelliSenseConfiguration: boolean = false;
+        const settings: CppSettings = new CppSettings(this.client.RootUri);
+        const hasConfigurationSet: boolean = settings.defaultCompilerPath !== undefined ||
+            !!settings.defaultCompileCommands || !!settings.defaultConfigurationProvider ||
+            this.client.configuration.CurrentConfiguration?.compilerPath !== undefined ||
+            !!this.client.configuration.CurrentConfiguration?.compileCommands ||
+            !!this.client.configuration.CurrentConfiguration?.configurationProvider ||
+            this.client.configuration.CurrentConfiguration?.compilerPathInCppPropertiesJson !== undefined ||
+            !!this.client.configuration.CurrentConfiguration?.compileCommandsInCppPropertiesJson ||
+            !!this.client.configuration.CurrentConfiguration?.configurationProviderInCppPropertiesJson;
 
         // Convert to vscode.CodeAction array
         response.commands.forEach((command) => {
@@ -173,15 +181,14 @@ export class CodeActionProvider implements vscode.CodeActionProvider {
                 return;
             } else if (command.command === 'C_Cpp.CreateDeclarationOrDefinition' && (command.arguments ?? []).length === 0) {
                 command.arguments = ['codeAction']; // We report the sender of the command
-            } else if (command.command === "C_Cpp.SelectDefaultCompiler") {
+            } else if (command.command === "C_Cpp.SelectIntelliSenseConfiguration") {
                 command.arguments = ['codeAction'];
-                hasSelectDefaultCompiler = true;
-                if (this.client.configuration.CurrentConfiguration?.rawCompilerPath !== undefined) {
-                    hasConfigurationCompilerPath = true;
+                hasSelectIntelliSenseConfiguration = true;
+                if (hasConfigurationSet) {
                     return;
                 }
-            } else if (command.command === "C_Cpp.ConfigurationEdit" && hasSelectDefaultCompiler) {
-                if (hasConfigurationCompilerPath) {
+            } else if (command.command === "C_Cpp.ConfigurationEdit" && hasSelectIntelliSenseConfiguration) {
+                if (hasConfigurationSet) {
                     title = title.replace("includePath", "compilerPath");
                 } else {
                     return;