Skip to content

Commit 361139f

Browse files
authored
Adding telemetry for devcmd environment usage (#14023)
1 parent cf9f23d commit 361139f

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

Extension/src/LanguageServer/cppBuildTaskProvider.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ class CustomBuildTaskTerminal implements Pseudoterminal {
436436
// However, this does not apply to processes that we spawn ourselves in the Pseudoterminal, so we need to specify the
437437
// correct environment in order to emulate the terminal behavior properly.
438438
this.options.env = getEffectiveEnvironment();
439+
telemetry.logLanguageServerEvent('buildUsesEnvironmentOverride');
439440
}
440441

441442
const splitWriteEmitter = (lines: string | Buffer) => {
@@ -498,18 +499,15 @@ class CustomBuildTaskTerminal implements Pseudoterminal {
498499

499500
private printBuildSummary(error: string, stdout: string, stderr: string, spawnResult: number): number {
500501
if (spawnResult !== 0) {
501-
telemetry.logLanguageServerEvent("cppBuildTaskError");
502502
this.writeEmitter.fire(localize("build.finished.with.error", "Build finished with error(s).") + this.endOfLine);
503503
return -1;
504504
}
505505
if (error || (!stdout && stderr && stderr.includes("error")) ||
506506
(stdout && (stdout.includes("error C") || stdout.includes("LINK : fatal error")))) { // cl.exe compiler errors
507-
telemetry.logLanguageServerEvent("cppBuildTaskError");
508507
this.writeEmitter.fire(localize("build.finished.with.error", "Build finished with error(s).") + this.endOfLine);
509508
return -1;
510509
} else if ((!stdout && stderr) || // gcc/clang
511510
(stdout && stdout.includes("warning C"))) { // cl.exe compiler warnings
512-
telemetry.logLanguageServerEvent("cppBuildTaskWarnings");
513511
this.writeEmitter.fire(localize("build.finished.with.warnings", "Build finished with warning(s).") + this.endOfLine);
514512
return 0;
515513
} else {

0 commit comments

Comments
 (0)