PR feedback

bobbrow · bobbrow · commit 371c0b164348 · 2025-08-29T16:56:53.000-07:00
diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts
@@ -2764,7 +2764,7 @@ export class DefaultClient implements Client {
         }
 
         const showExcessiveFilesWarning = new PersistentWorkspaceState<boolean>('CPP.showExcessiveFilesWarning', true);
-        if (!this.excessiveFilesWarningShown && notificationBody.event === 'ParsingStats' && showExcessiveFilesWarning.Value) {
+        if (!this.excessiveFilesWarningShown && showExcessiveFilesWarning.Value && notificationBody.event === 'ParsingStats') {
             const filesDiscovered = notificationBody.metrics?.filesDiscovered ?? 0;
             const parsableFiles = notificationBody.metrics?.parsableFiles ?? 0;
             if (filesDiscovered > 250000 || parsableFiles > 100000) {

Original file line number	Diff line number	Diff line change
`@@ -2764,7 +2764,7 @@ export class DefaultClient implements Client {`
`2764`	`2764`	`}`
`2765`	`2765`
`2766`	`2766`	`const showExcessiveFilesWarning = new PersistentWorkspaceState<boolean>('CPP.showExcessiveFilesWarning', true);`
`2767`		`- if (!this.excessiveFilesWarningShown && notificationBody.event === 'ParsingStats' && showExcessiveFilesWarning.Value) {`
	`2767`	`+ if (!this.excessiveFilesWarningShown && showExcessiveFilesWarning.Value && notificationBody.event === 'ParsingStats') {`
`2768`	`2768`	`const filesDiscovered = notificationBody.metrics?.filesDiscovered ?? 0;`
`2769`	`2769`	`const parsableFiles = notificationBody.metrics?.parsableFiles ?? 0;`
`2770`	`2770`	`if (filesDiscovered > 250000 \|\| parsableFiles > 100000) {`