Report the origin of the CreateDeclaration/Definition commands (#10582)

Author: bobbrow

Extension/src/LanguageServer/Providers/codeActionProvider.ts

@@ -169,6 +169,9 @@ export class CodeActionProvider implements vscode.CodeActionProvider {
                 resultCodeActions.push(...docCodeActions);
                 return;
             }
+            if (command.command === 'C_Cpp.CreateDeclarationOrDefinition' && (command.arguments ?? []).length === 0) {
+                command.arguments = ['codeAction']; // We report the sender of the command
+            }
             const vscodeCodeAction: vscode.CodeAction = {
                 title: title,
                 command: command.command === "edit" ? undefined : {

Extension/src/LanguageServer/extension.ts

@@ -425,16 +425,25 @@ export function registerCommands(enabled: boolean): void {
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.CreateDeclarationOrDefinition', enabled ? onCreateDeclarationOrDefinition : onDisabledCommand));
 }
 
-async function logForUIExperiment(command: string, sender?: any): Promise<void> {
+function logForUIExperiment(command: string, sender?: any): void {
     const settings: CppSettings = new CppSettings((vscode.workspace.workspaceFolders && vscode.workspace.workspaceFolders.length > 0) ? vscode.workspace.workspaceFolders[0]?.uri : undefined);
     const properties: {[key: string]: string} = {
         newUI: ui.isNewUI.toString(),
         uiOverride: (settings.experimentalFeatures ?? false).toString(),
-        sender: util.isString(sender) ? sender : 'commandPalette'
+        sender: getSenderType(sender)
     };
     telemetry.logLanguageServerEvent(`experiment${command}`, properties);
 }
 
+function getSenderType(sender?: any): string {
+    if (util.isString(sender)) {
+        return sender;
+    } else if (util.isUri(sender)) {
+        return 'contextMenu';
+    }
+    return 'commandPalette';
+}
+
 function onDisabledCommand(): void {
     const message: string = localize(
         {
@@ -675,7 +684,11 @@ async function onDisableAllTypeCodeAnalysisProblems(code: string, identifiersAnd
     getActiveClient().handleDisableAllTypeCodeAnalysisProblems(code, identifiersAndUris);
 }
 
-async function onCreateDeclarationOrDefinition(): Promise<void> {
+async function onCreateDeclarationOrDefinition(sender?: any): Promise<void> {
+    const properties: { [key: string]: string } = {
+        sender: getSenderType(sender)
+    };
+    telemetry.logLanguageServerEvent('CreateDeclDefn', properties);
     getActiveClient().handleCreateDeclarationOrDefinition();
 }