Fix for microsoft/vscode-extension-telemetry#7 (#1499)

* Fix for microsoft/vscode-extension-telemetry#7 .
* Filter out settings values that don't match enum values.

Author: sean-mcmanus

Extension/package-lock.json

@@ -1073,7 +1073,7 @@
     "tmp": "~0.0.33",
     "vscode-debugadapter": "~1.24.0",
     "vscode-debugprotocol": "~1.24.0",
-    "vscode-extension-telemetry": "~0.0.10",
+    "vscode-extension-telemetry": "~0.0.11",
     "vscode-languageclient": "~3.4.5",
     "yauzl": "~2.8.0"
   },

Extension/package.json

@@ -132,6 +132,15 @@ function collectSettingsForTelemetry(filter: (key: string, val: string, settings
         if (val instanceof Object) {
             continue; // ignore settings that are objects since tostring on those is not useful (e.g. navigation.length)
         }
+
+        // Skip values that don't match the setting's enum.
+        let curSetting: any = util.packageJson.contributes.configuration.properties["C_Cpp." + key];
+        if (curSetting) {
+            let curEnum: any[] = curSetting["enum"];
+            if (curEnum && curEnum.indexOf(val) === -1)
+                continue;
+        }
+
         if (filter(key, val, settings)) {
             previousCppSettings[key] = val;
             switch (String(key).toLowerCase()) {