bypass launch.json (#6072)

Author: Elaheh Rashedi

Extension/src/Debugger/extension.ts

@@ -108,11 +108,17 @@ export function initialize(context: vscode.ExtensionContext): void {
 
             // Attempt to use the user's (possibly) modified configuration before using the generated one.
             try {
-                await vscode.debug.startDebugging(folder, selection.configuration.name);
-                Telemetry.logDebuggerEvent("buildAndDebug", { "success": "true" });
+                await util.ensureDebugConfigExists(selection.configuration.name);
+                try {
+                    await vscode.debug.startDebugging(folder, selection.configuration.name);
+                    Telemetry.logDebuggerEvent("buildAndDebug", { "success": "true" });
+                } catch (e) {
+                    Telemetry.logDebuggerEvent("buildAndDebug", { "success": "false" });
+                }
             } catch (e) {
                 try {
                     vscode.debug.startDebugging(folder, selection.configuration);
+                    Telemetry.logDebuggerEvent("buildAndDebug", { "success": "true" });
                 } catch (e) {
                     Telemetry.logDebuggerEvent("buildAndDebug", { "success": "false" });
                 }

Extension/src/common.ts

@@ -62,8 +62,17 @@ export function getRawPackageJson(): any {
     return rawPackageJson;
 }
 
+export async function getRawLaunchJson(): Promise<any> {
+    const path: string | undefined = getLaunchJsonPath();
+    return getRawJson(path);
+}
+
 export async function getRawTasksJson(): Promise<any> {
     const path: string | undefined = getTasksJsonPath();
+    return getRawJson(path);
+}
+
+async function getRawJson(path: string | undefined): Promise<any> {
     if (!path) {
         return {};
     }
@@ -82,6 +91,24 @@ export async function getRawTasksJson(): Promise<any> {
     return rawTasks;
 }
 
+export async function ensureDebugConfigExists(configName: string): Promise<void> {
+    const launchJsonPath: string | undefined = getLaunchJsonPath();
+    if (!launchJsonPath) {
+        throw new Error("Failed to get launchJsonPath in ensureDebugConfigExists()");
+    }
+
+    const rawLaunchJson: any = await getRawLaunchJson();
+    // Ensure that the debug configurations exists in the user's launch.json. Config will not be found otherwise.
+    if (!rawLaunchJson || !rawLaunchJson.configurations) {
+        throw new Error(`Configuration '${configName}' is missing in 'launch.json'.`);
+    }
+    const selectedConfig: vscode.Task | undefined = rawLaunchJson.configurations.find((config: any) => config.name && config.name === configName);
+    if (!selectedConfig) {
+        throw new Error(`Configuration '${configName}' is missing in 'launch.json'.`);
+    }
+    return;
+}
+
 export async function ensureBuildTaskExists(taskLabel: string): Promise<void> {
     const rawTasksJson: any = await getRawTasksJson();
 
@@ -159,7 +186,15 @@ export function getPackageJsonPath(): string {
     return getExtensionFilePath("package.json");
 }
 
+export function getLaunchJsonPath(): string | undefined {
+    return getJsonPath("launch.json");
+}
+
 export function getTasksJsonPath(): string | undefined {
+    return getJsonPath("tasks.json");
+}
+
+function getJsonPath(jsonFilaName: string): string | undefined {
     const editor: vscode.TextEditor | undefined = vscode.window.activeTextEditor;
     if (!editor) {
         return undefined;
@@ -168,7 +203,7 @@ export function getTasksJsonPath(): string | undefined {
     if (!folder) {
         return undefined;
     }
-    return path.join(folder.uri.fsPath, ".vscode", "tasks.json");
+    return path.join(folder.uri.fsPath, ".vscode", jsonFilaName);
 }
 
 export function getVcpkgPathDescriptorFile(): string {