Dev/seanmcm/fix blank config with file watcher limit (#1709)

Fix blank config in the status bar (and browse engine stuck initializing) when the file watcher limit is hit.

Author: sean-mcmanus

Extension/src/LanguageServer/configurations.ts

@@ -346,13 +346,18 @@ export class CppProperties {
                 filePaths.add(c.compileCommands);
             }
         });
-        filePaths.forEach((path: string) => {
-            this.compileCommandFileWatchers.push(fs.watch(path, (event: string, filename: string) => {
-                if (event !== "rename") {
-                    this.onCompileCommandsChanged(path);
-                }
-            }));
-        });
+        try {
+            filePaths.forEach((path: string) => {
+                this.compileCommandFileWatchers.push(fs.watch(path, (event: string, filename: string) => {
+                    if (event !== "rename") {
+                        this.onCompileCommandsChanged(path);
+                    }
+                }));
+            });
+        } catch (e) {
+            // The file watcher limit is hit.
+            // TODO: Check if the compile commands file has a higher timestamp during the interval timer.
+        }
     }
 
     public handleConfigurationEditCommand(onSuccess: (document: vscode.TextDocument) => void): void {

Extension/src/LanguageServer/extension.ts

@@ -384,29 +384,33 @@ function reportMacCrashes(): void {
             }
 
             // vscode.workspace.createFileSystemWatcher only works in workspace folders.
-            fs.watch(crashFolder, (event, filename) => {
-                if (event !== "rename") {
-                    return;
-                }
-                if (filename === prevCrashFile) {
-                    return;
-                }
-                prevCrashFile = filename;
-                if (!filename.startsWith("Microsoft.VSCode.CPP.")) {
-                    return;
-                }
-                // Wait 5 seconds to allow time for the crash log to finish being written.
-                setTimeout(() => {
-                    fs.readFile(path.resolve(crashFolder, filename), 'utf8', (err, data) => {
-                        if (err) {
-                            // Try again?
-                            fs.readFile(path.resolve(crashFolder, filename), 'utf8', handleCrashFileRead);
-                            return;
-                        }
-                        handleCrashFileRead(err, data);
-                    });
-                }, 5000);
-            });
+            try {
+                fs.watch(crashFolder, (event, filename) => {
+                    if (event !== "rename") {
+                        return;
+                    }
+                    if (filename === prevCrashFile) {
+                        return;
+                    }
+                    prevCrashFile = filename;
+                    if (!filename.startsWith("Microsoft.VSCode.CPP.")) {
+                        return;
+                    }
+                    // Wait 5 seconds to allow time for the crash log to finish being written.
+                    setTimeout(() => {
+                        fs.readFile(path.resolve(crashFolder, filename), 'utf8', (err, data) => {
+                            if (err) {
+                                // Try again?
+                                fs.readFile(path.resolve(crashFolder, filename), 'utf8', handleCrashFileRead);
+                                return;
+                            }
+                            handleCrashFileRead(err, data);
+                        });
+                    }, 5000);
+                });
+            } catch (e) {
+                // The file watcher limit is hit (may not be possible on Mac, but just in case).
+            }
         });
     }
 }