Latest update from @fearthecowboy. Still need to review lint issues.

Author: bobbrow

Extension/package.json

@@ -6510,9 +6510,6 @@
                     "attach": {
                         "type": "object",
                         "default": {},
-                        "required": [
-                            "program"
-                        ],
                         "properties": {
                             "program": {
                                 "type": "string",
@@ -8040,7 +8037,7 @@
         "xml2js": "^0.6.2"
     },
     "dependencies": {
-        "@github/copilot-language-server": "^1.266.0",
+        "@github/copilot-language-server": "^1.316.0",
         "@vscode/extension-telemetry": "^0.9.6",
         "chokidar": "^3.6.0",
         "comment-json": "^4.2.3",

Extension/package.nls.json

@@ -951,6 +951,10 @@
     "c_cpp.debuggers.vsCodeCommand.description": "VS Code command to be invoked. Can be a command in VS Code or an active extension.",
     "c_cpp.debuggers.vsCodeCommand.command.description": "VS Code command to be invoked.",
     "c_cpp.debuggers.vsCodeCommand.args.description": "Arguments to the VS Code command.",
+    "c_cpp.debuggers.cpplldb.type.description": "The type of the engine. Must be \"cpplldb\".",
+    "c_cpp.debuggers.debuggerPath.description": "Full path to the LLDB-DAP debugger executable. If not specified, the extension will search for the debugger in the system PATH.",
+    "c_cpp.debuggers.debuggerArgs.description": "Additional arguments for the LLDB-DAP debugger.",
+    "c_cpp.debuggers.cpplldb.externalConsole.description": "If true, launch the external console for the debugger.",
     "c_cpp.debuggers.cpplldb.debuggerPath.description": "Full path to the LLDB-DAP debugger executable. If not specified, the extension will search for the debugger in the system PATH.",
     "c_cpp.debuggers.cpplldb.debuggerArgs.description": "Additional arguments for the LLDB-DAP debugger.",
     "c_cpp.debuggers.cpplldb.disableAslr.description": "Disable Address Space Layout Randomization (if supported).",

Extension/src/Debugger/attachToProcess.ts

@@ -12,6 +12,7 @@ import * as path from 'path';
 import * as vscode from 'vscode';
 import * as nls from 'vscode-nls';
 import * as util from '../common';
+import { executableName, ProcessReturnType, spawnChildProcess } from '../common-remote-safe';
 import * as debugUtils from './utils';
 
 nls.config({ messageFormat: nls.MessageFormat.bundle, bundleFormat: nls.BundleFormat.standalone })();
@@ -21,12 +22,26 @@ export interface AttachItemsProvider {
     getAttachItems(token?: vscode.CancellationToken): Promise<AttachItem[]>;
 }
 
+/**
+ * Determines if a process matches the specified filter criteria.
+ *
+ * This function checks if the given process name or its full path matches
+ * the provided filter string. It also normalizes the filter string to handle
+ * relative paths and compares the executable name derived from the filter
+ * with the executable name of the process.
+ *
+ * @param filterTo - The filter string to match against. This can be a process name,
+ *                   an executable name, or a file path.
+ * @param processName - The name of the process to check.
+ * @param fullPath - The full path of the process executable, if available.
+ * @returns `true` if the process matches the filter criteria; otherwise, `false`.
+ */
 export function processMatches(filterTo: string, processName: string, fullPath: string | undefined) {
     const normalized = path.resolve(filterTo);
-    const executable = util.executableName(filterTo);
+    const executable = executableName(filterTo);
 
     // Filter out the processes that do not somehow match.
-    return processName === filterTo || util.executableName(processName) === executable || fullPath === filterTo || fullPath === normalized;
+    return processName === filterTo || executableName(processName) === executable || fullPath === filterTo || fullPath === normalized;
 }
 
 export class AttachPicker {
@@ -209,10 +224,10 @@ export class RemoteAttachPicker {
 
     private async getRemoteProcessesExtendedRemote(miDebuggerPath: string, miDebuggerServerAddress: string): Promise<AttachItem[]> {
         const args: string[] = [`-ex "target extended-remote ${miDebuggerServerAddress}"`, '-ex "info os processes"', '-batch'];
-        let processListOutput: util.ProcessReturnType = await util.spawnChildProcess(miDebuggerPath, args);
+        let processListOutput: ProcessReturnType = await spawnChildProcess(miDebuggerPath, args);
         // The device may not be responsive for a while during the restart after image deploy. Retry 5 times.
         for (let i: number = 0; i < 5 && !processListOutput.succeeded && processListOutput.outputError.length === 0; i++) {
-            processListOutput = await util.spawnChildProcess(miDebuggerPath, args);
+            processListOutput = await spawnChildProcess(miDebuggerPath, args);
         }
 
         if (!processListOutput.succeeded) {

Extension/src/Debugger/configurationProvider.ts

@@ -12,6 +12,7 @@ import { promisify } from 'util';
 import * as vscode from 'vscode';
 import * as nls from 'vscode-nls';
 import * as util from '../common';
+import { executableName, ProcessReturnType, spawnChildProcess } from '../common-remote-safe';
 import { isWindows } from '../constants';
 import { expandAllStrings, ExpansionOptions, ExpansionVars } from '../expand';
 import { CppBuildTask, CppBuildTaskDefinition, cppBuildTaskProvider } from '../LanguageServer/cppBuildTaskProvider';
@@ -527,25 +528,27 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
                         newConfig.type = DebuggerType.cppvsdbg;
                         return newConfig;
                     } else {
-                        debuggerName = util.executableName("gdb");
+                        debuggerName = executableName("gdb");
                     }
                     const compilerDirname: string = path.dirname(compilerPath);
                     const debuggerPath: string = path.join(compilerDirname, debuggerName);
 
-                    // Check if debuggerPath exists.
-                    if (await util.checkFileExists(debuggerPath)) {
-                        newConfig.miDebuggerPath = debuggerPath;
-                    } else if (await util.whichAsync(debuggerName) !== undefined) {
-                        // Check if debuggerName exists on $PATH
-                        newConfig.miDebuggerPath = debuggerName;
-                    } else {
-                        // Try the usr path for non-Windows platforms.
-                        const usrDebuggerPath: string = path.join("/usr", "bin", debuggerName);
-                        if (!isWindows && await util.checkFileExists(usrDebuggerPath)) {
-                            newConfig.miDebuggerPath = usrDebuggerPath;
+                    if (newConfig.type === DebuggerType.cppdbg) {
+                        // Check if debuggerPath exists.
+                        if (await util.checkFileExists(debuggerPath)) {
+                            newConfig.miDebuggerPath = debuggerPath;
+                        } else if (await util.whichAsync(debuggerName) !== undefined) {
+                            // Check if debuggerName exists on $PATH
+                            newConfig.miDebuggerPath = debuggerName;
                         } else {
-                            logger.getOutputChannelLogger().appendLine(localize('debugger.path.not.exists', "Unable to find the {0} debugger. The debug configuration for {1} is ignored.", `\"${debuggerName}\"`, compilerName));
-                            return undefined;
+                            // Try the usr path for non-Windows platforms.
+                            const usrDebuggerPath: string = path.join("/usr", "bin", debuggerName);
+                            if (!isWindows && await util.checkFileExists(usrDebuggerPath)) {
+                                newConfig.miDebuggerPath = usrDebuggerPath;
+                            } else {
+                                logger.getOutputChannelLogger().appendLine(localize('debugger.path.not.exists', "Unable to find the {0} debugger. The debug configuration for {1} is ignored.", `\"${debuggerName}\"`, compilerName));
+                                return undefined;
+                            }
                         }
                     }
                 }
@@ -1126,7 +1129,7 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
                     return false;
                 }
 
-                let scpResult: util.ProcessReturnType;
+                let scpResult: ProcessReturnType;
                 if (isScp) {
                     scpResult = await scp(files, host, step.targetDir, config.scpPath, config.recursive, jumpHosts, cancellationToken);
                 } else {
@@ -1147,7 +1150,7 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
                 const jumpHosts: util.ISshHostInfo[] = step.host.jumpHosts;
                 const localForwards: util.ISshLocalForwardInfo[] = step.host.localForwards;
                 const continueOn: string = step.continueOn;
-                const sshResult: util.ProcessReturnType = await ssh(host, step.command, config.sshPath, jumpHosts, localForwards, continueOn, cancellationToken);
+                const sshResult: ProcessReturnType = await ssh(host, step.command, config.sshPath, jumpHosts, localForwards, continueOn, cancellationToken);
                 if (!sshResult.succeeded || cancellationToken?.isCancellationRequested) {
                     return false;
                 }
@@ -1158,7 +1161,7 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
                     void logger.getOutputChannelLogger().showErrorMessage(localize('missing.properties.shell', '"command" is required for shell steps.'));
                     return false;
                 }
-                const taskResult: util.ProcessReturnType = await util.spawnChildProcess(step.command, undefined, step.continueOn);
+                const taskResult: ProcessReturnType = await spawnChildProcess(step.command, undefined, step.continueOn);
                 if (!taskResult.succeeded || cancellationToken?.isCancellationRequested) {
                     void logger.getOutputChannelLogger().showErrorMessage(taskResult.output);
                     return false;

Extension/src/Debugger/extension.ts

@@ -14,7 +14,7 @@ import { SshTargetsProvider, getActiveSshTarget, initializeSshTargets, selectSsh
 import { TargetLeafNode, setActiveSshTarget } from '../SSH/TargetsView/targetNodes';
 import { sshCommandToConfig } from '../SSH/sshCommandToConfig';
 import { getSshConfiguration, getSshConfigurationFiles, parseFailures, writeSshConfiguration } from '../SSH/sshHosts';
-import { pathAccessible } from '../common';
+import { pathAccessible } from '../common-remote-safe';
 import { instrument } from '../instrumentation';
 import { getSshChannel } from '../logger';
 import { AttachItemsProvider, AttachPicker, RemoteAttachPicker } from './attachToProcess';