address feedback

Author: fearthecowboy

Extension/package.json

@@ -5799,8 +5799,6 @@
                     "cuda-cpp",
                     "rust"
                 ],
-                "_aiKeyComment": "Ignore 'Property aiKey is not allowed'. See https://github.com/microsoft/vscode/issues/76493",
-                "aiKey": "0c6ae279ed8443289764825290e4f9e2-1a736e7c-1324-4338-be46-fc2a58ae4d14-7255",
                 "variables": {
                     "pickProcess": "extension.pickNativeProcess",
                     "pickRemoteProcess": "extension.pickRemoteNativeProcess"
@@ -8068,4 +8066,4 @@
         "postcss": "^8.4.31",
         "gulp-typescript/**/glob-parent": "^5.1.2"
     }
-}
+}

Extension/package.nls.json

@@ -891,7 +891,7 @@
     "c_cpp.debuggers.miDebuggerArgs.description": "Additional arguments for the MI debugger (such as gdb).",
     "c_cpp.debuggers.miDebuggerServerAddress.description": "Network address of the MI Debugger Server to connect to (example: localhost:1234).",
     "c_cpp.debuggers.useExtendedRemote.description": "Connect to the MI Debugger Server with target extended-remote mode.",
-    "c_cpp.debuggers.stopAtEntry.description": "Optional parameter. If true, the debugger should stop at the entrypoint of the target. If `processId` is passed, has no effect.",
+    "c_cpp.debuggers.stopAtEntry.description": "Optional parameter. If true, the debugger should stop at the entrypoint of the target. If processId is passed, has no effect.",
     "c_cpp.debuggers.debugServerPath.description": "Optional full path to the debug server to launch. Defaults to null. It is used in conjunction with either \"miDebugServerAddress\" or your own server with a \"customSetupCommand\" that runs \"-target-select remote <server:port>\".",
     "c_cpp.debuggers.debugServerArgs.description": "Optional debug server args. Defaults to null.",
     "c_cpp.debuggers.serverStarted.description": "Optional server-started pattern to look for in the debug server output. Defaults to null.",

Extension/src/Debugger/configurationProvider.ts

@@ -377,7 +377,9 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
 
                                 // They did specify 'waitFor' so then let's get out fast and let lldb-dap handle it.
                                 logger.note(localize("waiting.for.process", "Waiting to attach process '{0}'", config.program));
-                                return translateToLldbDap(config);
+                                translateToLldbDap(config);
+                                Telemetry.logDebuggerEvent(config.request, { "debuggerType": config.type });
+                                return config;
                             }
 
                             // Just let the picker show all processes.
@@ -410,8 +412,11 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
         // Finish translating the config for lldb-dap.
         if (config.type === DebuggerType.cpplldb) {
             translateToLldbDap(config);
+            Telemetry.logDebuggerEvent(config.request, { "debuggerType": config.type });
+            return config;
         }
 
+        Telemetry.logDebuggerEvent(config.request, { "debuggerType": config.type, mimode: config.MIMode });
         return config;
     }