Perf-boost - fast query symbols (#11785)

* Perf-boost - fast query symbols

* Rebased, updated (moved to node 18.15.0+)

* quick cleanup

* remove unused linter directive

* Delete Extension/cpp.hint

That wasn't supposed to be here.

* restore file

---------

Co-authored-by: Sean McManus <[email protected]>

Author: fearthecowboy

Extension/package.json

@@ -6311,7 +6311,7 @@
         "@types/minimatch": "^3.0.5",
         "@types/mkdirp": "^0.5.2",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.11.9",
+        "@types/node": "^18.15.0",
         "@types/node-fetch": "^2.6.9",
         "@types/plist": "^3.0.2",
         "@types/semver": "^7.1.0",
@@ -6322,7 +6322,7 @@
         "@typescript-eslint/eslint-plugin": "^6.1.0",
         "@typescript-eslint/parser": "^6.1.0",
         "eslint-plugin-header": "^3.1.1",
-        "@vscode/test-electron": "^2.3.3",
+        "@vscode/test-electron": "^2.3.8",
         "@vscode/dts": "^0.4.0",
         "async-child-process": "^1.1.1",
         "await-notify": "^1.0.1",

Extension/src/LanguageServer/Providers/workspaceSymbolProvider.ts

@@ -3,6 +3,7 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 import * as vscode from 'vscode';
+import { isExperimentEnabled } from '../../telemetry';
 import { DefaultClient, GetSymbolInfoRequest, LocalizeSymbolInformation, SymbolScope, WorkspaceSymbolParams } from '../client';
 import { getLocalizedString, getLocalizedSymbolScope } from '../localization';
 import { makeVscodeLocation } from '../utils';
@@ -14,8 +15,14 @@ export class WorkspaceSymbolProvider implements vscode.WorkspaceSymbolProvider {
     }
 
     public async provideWorkspaceSymbols(query: string, token: vscode.CancellationToken): Promise<vscode.SymbolInformation[]> {
+        // if the query is empty, then return as quickly as possible
+        if (!query) {
+            return [];
+        }
+
         const params: WorkspaceSymbolParams = {
-            query: query
+            query: query,
+            experimentEnabled: await isExperimentEnabled('CppTools1')
         };
 
         const symbols: LocalizeSymbolInformation[] = await this.client.languageClient.sendRequest(GetSymbolInfoRequest, params, token);

Extension/src/LanguageServer/client.ts

@@ -317,6 +317,7 @@ export interface GetDocumentSymbolRequestParams {
 
 export interface WorkspaceSymbolParams extends WorkspaceFolderParams {
     query: string;
+    experimentEnabled: boolean;
 }
 
 export enum SymbolScope {
@@ -2240,7 +2241,7 @@ export class DefaultClient implements Client {
     }
 
     private callTaskWithTimeout<T>(task: () => Thenable<T>, ms: number, cancelToken?: vscode.CancellationTokenSource): Promise<T> {
-        let timer: NodeJS.Timer;
+        let timer: NodeJS.Timeout;
 
         // Create a promise that rejects in <ms> milliseconds
         const timeout: () => Promise<T> = () => new Promise<T>((resolve, reject) => {

Extension/src/LanguageServer/configurations.ts

@@ -1108,7 +1108,7 @@ export class CppProperties {
         }
     }
 
-    private compileCommandsFileWatcherTimer?: NodeJS.Timer;
+    private compileCommandsFileWatcherTimer?: NodeJS.Timeout;
     private compileCommandsFileWatcherFiles: Set<string> = new Set<string>();
 
     // Dispose existing and loop through cpp and populate with each file (exists or not) as you go.

Extension/src/LanguageServer/extension.ts

@@ -43,7 +43,7 @@ let ui: LanguageStatusUI;
 const disposables: vscode.Disposable[] = [];
 const commandDisposables: vscode.Disposable[] = [];
 let languageConfigurations: vscode.Disposable[] = [];
-let intervalTimer: NodeJS.Timer;
+let intervalTimer: NodeJS.Timeout;
 let codeActionProvider: vscode.Disposable;
 export const intelliSenseDisabledError: string = "Do not activate the extension when IntelliSense is disabled.";
 

Extension/src/cppTools.ts

@@ -20,7 +20,7 @@ export class CppTools implements CppToolsTestApi {
     private version: Version;
     private providers: CustomConfigurationProvider1[] = [];
     private failedRegistrations: CustomConfigurationProvider[] = [];
-    private timers = new Map<string, NodeJS.Timer>();
+    private timers = new Map<string, NodeJS.Timeout>();
 
     constructor(version: Version) {
         if (version > Version.latest) {
@@ -34,7 +34,7 @@ export class CppTools implements CppToolsTestApi {
     private addNotifyReadyTimer(provider: CustomConfigurationProvider1): void {
         if (this.version >= Version.v2) {
             const timeout: number = 30;
-            const timer: NodeJS.Timer = global.setTimeout(() => {
+            const timer: NodeJS.Timeout = global.setTimeout(() => {
                 console.warn(`registered provider ${provider.extensionId} did not call 'notifyReady' within ${timeout} seconds`);
             }, timeout * 1000);
             this.timers.set(provider.extensionId, timer);
@@ -43,7 +43,7 @@ export class CppTools implements CppToolsTestApi {
 
     private removeNotifyReadyTimer(provider: CustomConfigurationProvider1): void {
         if (this.version >= Version.v2) {
-            const timer: NodeJS.Timer | undefined = this.timers.get(provider.extensionId);
+            const timer: NodeJS.Timeout | undefined = this.timers.get(provider.extensionId);
             if (timer) {
                 this.timers.delete(provider.extensionId);
                 clearTimeout(timer);

Extension/src/telemetry.ts

@@ -79,9 +79,7 @@ export function getExperimentationService(): Promise<IExperimentationService> |
     return initializationPromise;
 }
 
-// @ts-expect-error The function isExperimentEnabled will be used for future experiments.
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-async function isExperimentEnabled(experimentName: string): Promise<boolean> {
+export async function isExperimentEnabled(experimentName: string): Promise<boolean> {
     if (new CppSettings().experimentalFeatures) {
         return true;
     }