disable the config provider message for headers outside the workspace & while debugging (#2239)

* disable the config provider message for headers & while debugging

* leave the message on for headers inside the workspace folder

Author: bobbrow

Extension/src/LanguageServer/client.ts

@@ -513,9 +513,17 @@ class DefaultClient implements Client {
                 }
             },
             () => {
-                vscode.window.showInformationMessage(`'${providerName}' is unable to provide IntelliSense configuration information for '${document.uri.fsPath}'. Settings from the '${configName}' configuration will be used instead.`);
+                if (!this.isExternalHeader(document) && !vscode.debug.activeDebugSession) {
+                    vscode.window.showInformationMessage(
+                        `'${providerName}' is unable to provide IntelliSense configuration information for '${document.uri.fsPath}'. ` +
+                        `Settings from the '${configName}' configuration will be used instead.`);
+                }
             });
     }
+
+    private isExternalHeader(document: vscode.TextDocument): boolean {
+        return util.isHeader(document) && !document.uri.toString().startsWith(this.RootUri.toString());
+    }
 
     public getCustomConfigurationProviderId(): Thenable<string|undefined> {
         return this.queueTask(() => Promise.resolve(this.configuration.CurrentConfiguration.configurationProvider));

Extension/src/common.ts

@@ -73,6 +73,16 @@ export function getVcpkgRoot(): string {
     return vcpkgRoot;
 }
 
+/**
+ * This is a fuzzy determination of whether a uri represents a header file.
+ * For the purposes of this function, a header file has no extension, or an extension that begins with the letter 'h'.
+ * @param document The document to check.
+ */
+export function isHeader(document: vscode.TextDocument): boolean {
+    let ext: string = path.extname(document.uri.fsPath);
+    return !ext || ext.startsWith(".h") || ext.startsWith(".H");
+}
+
 // Extension is ready if install.lock exists and debugAdapters folder exist.
 export async function isExtensionReady(): Promise<boolean> {
     const doesInstallLockFileExist: boolean = await checkInstallLockFile();