Skip to content

Commit 7c185ba

Browse files
committed
don't run these tests on linux/mac yet
1 parent 6d0d78a commit 7c185ba

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

.github/workflows/job-compile-and-test.yml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,22 +21,6 @@ jobs:
2121
steps:
2222
- uses: actions/checkout@v4
2323

24-
- name: Install latest version of the C++ extension
25-
if: ${{ inputs.platform != 'windows' }}
26-
run: |
27-
code --install-extension ms-vscode.cpptools --force --pre-release
28-
29-
- name: Copy binaries from the C++ extension
30-
if: ${{ inputs.platform != 'windows' }}
31-
run: |
32-
cp -r ~/.vscode/extensions/ms-vscode.cpptools-1.*/bin/* ./Extension/bin
33-
shell: bash
34-
35-
- name: Uninstall the C++ extension
36-
if: ${{ inputs.platform != 'windows' }}
37-
run: |
38-
code --uninstall-extension ms-vscode.cpptools
39-
4024
- name: Use Node.js 22
4125
uses: actions/setup-node@v4
4226
with:
@@ -58,7 +42,11 @@ jobs:
5842
run: yarn test
5943
working-directory: Extension
6044

45+
# These tests don't require the binary.
46+
# On Linux, it is failing (before the tests actually run) with: Test run terminated with signal SIGSEGV.
47+
# But it works on Linux during the E2E test.
6148
- name: Run SingleRootProject tests
49+
if: ${{ inputs.platform != 'linux' }}
6250
run: yarn test --scenario=SingleRootProject --skipCheckBinaries
6351
working-directory: Extension
6452

Extension/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ server
1010
debugAdapters
1111
LLVM
1212
bin/cpptools*
13+
bin/libc.so
1314
bin/*.dll
1415
bin/.vs
1516
bin/LICENSE.txt

Extension/test/scenarios/SingleRootProject/tests/compilerPath.test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import { describe, it } from 'mocha';
77
import { deepEqual, equal, ok } from 'node:assert';
8+
import { skip } from 'node:test';
89
import * as path from 'path';
910
import { Uri } from 'vscode';
1011
import { extractCompilerPathAndArgs, setExtensionPath } from '../../../../src/common';
@@ -113,6 +114,8 @@ if (isWindows) {
113114
// The extension is not initialized the same way during tests, so this needs to be set manually
114115
// so the tests can find `cpptools-wordexp`.
115116
setExtensionPath(extensionPath);
117+
skip();
118+
return;
116119

117120
// [compilerPath, useLegacyBehavior, additionalArgs, result.compilerName, result.allCompilerArgs]
118121
const tests: [string, boolean, string[] | undefined, string, string[]][] = [
@@ -181,6 +184,8 @@ describe('validateCompilerPath', () => {
181184
// The extension is not initialized the same way during tests, so this needs to be set manually
182185
// so the tests can find `cpptools-wordexp`.
183186
setExtensionPath(extensionPath);
187+
skip();
188+
return;
184189
}
185190

186191
// [compilerPath, cwd, result.compilerName, result.allCompilerArgs, result.error, result.telemetry]

0 commit comments

Comments
 (0)