Remove shallow document copy and prevent extension activation on Untitled (#4144)

* Remove shallow document copy and prevent extension activation on Untitled.

Author: sean-mcmanus

Extension/CHANGELOG.md

@@ -1,11 +1,16 @@
 # C/C++ for Visual Studio Code Change Log
 
-## Version 0.25.1: August 26, 2019
+## Version 0.25.1: August 27, 2019
 ### Bug Fixes
 * Fix `Switch Header/Source` for `.H` and `.C` targets. [#3048](https://github.com/microsoft/vscode-cpptools/issues/3048)
+* Fix duplicate content appearing after formatting of a new file (2nd fix). [#4091](https://github.com/microsoft/vscode-cpptools/issues/4091)
 * Fix links in `Log Diagnostics` output. [#4122](https://github.com/microsoft/vscode-cpptools/issues/4122)
 * Fix `NullReferenceException` when debugging if `"description"` is missing. [#4125}(https://github.com/microsoft/vscode-cpptools/issues/4125)
 * Fix `files.exclude` processing when using `\\`. [#4127](https://github.com/microsoft/vscode-cpptools/issues/4127)
+* Fix bug when attaching to an elevated process using GDB. [#4133](https://github.com/microsoft/vscode-cpptools/issues/4133)
+* Fix IntelliSense-based `Go to Definition` failing for a nested class in a template class. [#4135](https://github.com/microsoft/vscode-cpptools/issues/4135)
+* Fix incorrect configuration squiggles with `compilerPath` when variables are used. [#4141](https://github.com/microsoft/vscode-cpptools/issues/4141)
+  * @mistersandman [PR #4142](https://github.com/microsoft/vscode-cpptools/pull/4142)
 
 ## Version 0.25.0: August 21, 2019
 ### New Features

Extension/src/LanguageServer/extension.ts

@@ -220,9 +220,11 @@ export function activate(activationEventOccurred: boolean): void {
     if (vscode.workspace.textDocuments !== undefined && vscode.workspace.textDocuments.length > 0) {
         for (let i: number = 0; i < vscode.workspace.textDocuments.length; ++i) {
             let document: vscode.TextDocument = vscode.workspace.textDocuments[i];
-            if (document.languageId === "cpp" || document.languageId === "c") {
-                onActivationEvent();
-                return;
+            if (document.uri.scheme === "file") {
+                if (document.languageId === "cpp" || document.languageId === "c") {
+                    onActivationEvent();
+                    return;
+                }
             }
         }
     }
@@ -517,7 +519,7 @@ function onDidChangeActiveTextEditor(editor: vscode.TextEditor): void {
     }
 
     let activeEditor: vscode.TextEditor = vscode.window.activeTextEditor;
-    if (!activeEditor || (activeEditor.document.languageId !== "cpp" && activeEditor.document.languageId !== "c")) {
+    if (!activeEditor || activeEditor.document.uri.scheme !== "file" || (activeEditor.document.languageId !== "cpp" && activeEditor.document.languageId !== "c")) {
         activeDocument = "";
     } else {
         activeDocument = editor.document.uri.toString();
@@ -530,6 +532,7 @@ function onDidChangeActiveTextEditor(editor: vscode.TextEditor): void {
 function onDidChangeTextEditorSelection(event: vscode.TextEditorSelectionChangeEvent): void {
     /* need to notify the affected client(s) */
     if (!event.textEditor || !vscode.window.activeTextEditor || event.textEditor.document.uri !== vscode.window.activeTextEditor.document.uri ||
+        event.textEditor.document.uri.scheme !== "file" ||
         (event.textEditor.document.languageId !== "cpp" && event.textEditor.document.languageId !== "c")) {
         return;
     }

Extension/src/LanguageServer/protocolFilter.ts

@@ -5,7 +5,6 @@
 'use strict';
 
 import * as path from 'path';
-import { TextDocument } from 'vscode';
 import { Middleware } from 'vscode-languageclient';
 import { ClientCollection } from './clientCollection';
 import { Client } from './client';
@@ -35,13 +34,8 @@ export function createProtocolFilter(me: Client, clients: ClientCollection): Mid
 
                 me.onDidOpenTextDocument(document);
 
-                // 'document' is a reference to the live TextDocument. Because the document can change while we wait for
-                // custom configurations, we must clone the current state of the object before yielding the thread.
-                // Theoretically, we should do this everywhere, but there are no other callbacks that read the document
-                // state directly (just the Uri) so there doesn't appear to be a need to do it.
-                const documentCopy: TextDocument = {...document};
                 me.provideCustomConfiguration(document.uri, null);
-                me.notifyWhenReady(() => sendMessage(documentCopy));
+                me.notifyWhenReady(() => sendMessage(document));
             }
         },
         didChange: (textDocumentChangeEvent, sendMessage) => {

Extension/src/LanguageServer/ui.ts

@@ -158,7 +158,7 @@ export class UI {
 
     public activeDocumentChanged(): void {
         let activeEditor: vscode.TextEditor = vscode.window.activeTextEditor;
-        let isCpp: boolean = (activeEditor && (activeEditor.document.languageId === "cpp" || activeEditor.document.languageId === "c"));
+        let isCpp: boolean = (activeEditor && activeEditor.document.uri.scheme === "file" && (activeEditor.document.languageId === "cpp" || activeEditor.document.languageId === "c"));
 
         // It's sometimes desirable to see the config and icons when making settings changes.
         let isSettingsJson: boolean = (activeEditor && (activeEditor.document.fileName.endsWith("c_cpp_properties.json") || activeEditor.document.fileName.endsWith("settings.json")));