Skip to content

Commit 8aac573

Browse files
authored
Check extensions.autoUpdate. (#4151)
1 parent 7b1677e commit 8aac573

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Extension/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
# C/C++ for Visual Studio Code Change Log
22

3-
## Version 0.25.1: August 27, 2019
3+
## Version 0.25.1: August 28, 2019
44
### Bug Fixes
55
* Fix `Switch Header/Source` for `.H` and `.C` targets. [#3048](https://github.com/microsoft/vscode-cpptools/issues/3048)
6+
* Fix `C_Cpp.updateChannel` not respecting `extensions.autoUpdate`. [#3632](https://github.com/microsoft/vscode-cpptools/issues/3632)
67
* Fix duplicate content appearing after formatting of a new file (2nd fix). [#4091](https://github.com/microsoft/vscode-cpptools/issues/4091)
78
* Fix links in `Log Diagnostics` output. [#4122](https://github.com/microsoft/vscode-cpptools/issues/4122)
8-
* Fix `NullReferenceException` when debugging if `"description"` is missing. [#4125}(https://github.com/microsoft/vscode-cpptools/issues/4125)
9+
* Fix `NullReferenceException` when debugging if `"description"` is missing. [#4125](https://github.com/microsoft/vscode-cpptools/issues/4125)
910
* Fix `files.exclude` processing when using `\\`. [#4127](https://github.com/microsoft/vscode-cpptools/issues/4127)
1011
* Fix bug when attaching to an elevated process using GDB. [#4133](https://github.com/microsoft/vscode-cpptools/issues/4133)
1112
* Fix IntelliSense-based `Go to Definition` failing for a nested class in a template class. [#4135](https://github.com/microsoft/vscode-cpptools/issues/4135)

Extension/src/githubAPI.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { PackageVersion } from './packageVersion';
88
import * as util from './common';
99
import { PlatformInformation } from './platform';
1010
import { OutgoingHttpHeaders } from 'http';
11+
import * as vscode from 'vscode';
1112

1213
const testingInsidersVsixInstall: boolean = false; // Change this to true to enable testing of the Insiders vsix installation.
1314

@@ -170,6 +171,10 @@ export async function getTargetBuildInfo(updateChannel: string): Promise<BuildIn
170171
* @return The Build if the user should update to it, otherwise undefined.
171172
*/
172173
function getTargetBuild(builds: Build[], userVersion: PackageVersion, updateChannel: string): Build {
174+
if (!vscode.workspace.getConfiguration("extensions", null).get<boolean>("autoUpdate")) {
175+
return undefined;
176+
}
177+
173178
// Get predicates to determine the build to install, if any
174179
let needsUpdate: (installed: PackageVersion, target: PackageVersion) => boolean;
175180
let useBuild: (build: Build) => boolean;

0 commit comments

Comments
 (0)