Address some issues where spread operator was used but deep copy needed (#10803)

Author: Colengms

Extension/package.json

@@ -6004,8 +6004,8 @@
     "@types/node": "^14.14.0",
     "@types/plist": "^3.0.2",
     "@types/semver": "^7.1.0",
-    "@types/tmp": "^0.1.0",
     "@types/shell-quote": "^1.7.1",
+    "@types/tmp": "^0.1.0",
     "@types/which": "^1.3.2",
     "@types/yauzl": "^2.9.1",
     "@typescript-eslint/eslint-plugin": "^4.31.1",
@@ -6043,12 +6043,14 @@
     "xml2js": "^0.5.0"
   },
   "dependencies": {
+    "@types/lodash": "^4.14.192",
     "@vscode/extension-telemetry": "^0.6.2",
     "chokidar": "^3.5.3",
     "comment-json": "^4.1.1",
     "editorconfig": "^0.15.3",
     "escape-string-regexp": "^2.0.0",
     "glob": "^7.1.6",
+    "lodash": "^4.17.21",
     "minimatch": "^3.0.5",
     "mkdirp": "^0.5.5",
     "node-loader": "^2.0.0",
@@ -6084,4 +6086,4 @@
     "yargs-parser": "^15.0.1",
     "y18n": "^5.0.5"
   }
-}
+}

Extension/src/LanguageServer/client.ts

@@ -51,7 +51,9 @@ import {
     removeCodeAnalysisProblems, RemoveCodeAnalysisProblemsParams
 } from './codeAnalysis';
 import { DebugProtocolParams, getDiagnosticsChannel, getOutputChannelLogger, logDebugProtocol, Logger, logLocalized, showWarning, ShowWarningParams } from '../logger';
+import _ = require('lodash');
 
+const deepCopy = (obj: any) => _.cloneDeep(obj);
 nls.config({ messageFormat: nls.MessageFormat.bundle, bundleFormat: nls.BundleFormat.standalone })();
 const localize: nls.LocalizeFunc = nls.loadMessageBundle();
 
@@ -2755,7 +2757,7 @@ export class DefaultClient implements Client {
         // Clone each entry, as we make modifications before sending it, and don't
         // want to add those modifications to the original objects.
         configurations.forEach((c) => {
-            const modifiedConfig: configs.Configuration = { ...c };
+            const modifiedConfig: configs.Configuration = deepCopy(c);
             // Separate compiler path and args before sending to language client
             const compilerPathAndArgs: util.CompilerPathAndArgs =
                 util.extractCompilerPathAndArgs(!!settings.legacyCompilerArgsBehavior, c.compilerPath, c.compilerArgs);
@@ -2868,7 +2870,7 @@ export class DefaultClient implements Client {
                     console.warn("custom include paths should not use recursive includes ('**')");
                 }
                 // Separate compiler path and args before sending to language client
-                const itemConfig: util.Mutable<InternalSourceFileConfiguration> = { ...item.configuration };
+                const itemConfig: util.Mutable<InternalSourceFileConfiguration> = deepCopy(item.configuration);
                 if (util.isString(itemConfig.compilerPath)) {
                     const compilerPathAndArgs: util.CompilerPathAndArgs = util.extractCompilerPathAndArgs(
                         providerVersion < Version.v6,
@@ -2946,7 +2948,8 @@ export class DefaultClient implements Client {
                 return;
             }
 
-            sanitized = { ...<InternalWorkspaceBrowseConfiguration>config };
+            const browseConfig: InternalWorkspaceBrowseConfiguration = <InternalWorkspaceBrowseConfiguration>config;
+            sanitized = deepCopy(browseConfig);
             if (!this.isWorkspaceBrowseConfiguration(sanitized)) {
                 console.log("Received an invalid browse configuration from configuration provider: " + JSON.stringify(sanitized));
                 const configValue: WorkspaceBrowseConfiguration | undefined = this.lastCustomBrowseConfiguration.Value;

Extension/src/LanguageServer/settingsPanel.ts

@@ -11,6 +11,9 @@ import * as util from '../common';
 import * as config from './configurations';
 import * as telemetry from '../telemetry';
 import { getLocalizedHtmlPath } from './localization';
+import _ = require('lodash');
+
+const deepCopy = (obj: any) => _.cloneDeep(obj);
 
 // TODO: share ElementId between SettingsPanel and SettingsApp. Investigate why SettingsApp cannot import/export
 const elementId: { [key: string]: string } = {
@@ -220,7 +223,7 @@ export class SettingsPanel {
     }
 
     private updateWebview(configSelection: string[], configuration: config.Configuration, errors: config.ConfigurationErrors | null): void {
-        this.configValues = {...configuration}; // Copy configuration values
+        this.configValues = deepCopy(configuration); // Copy configuration values
         this.isIntelliSenseModeDefined = (this.configValues.intelliSenseMode !== undefined);
         if (this.panel && this.initialized) {
             this.panel.webview.postMessage({ command: 'setKnownCompilers', compilers: this.compilerPaths });

Extension/yarn.lock

@@ -361,6 +361,11 @@
   resolved "https://registry.yarnpkg.com/@types/json5/-/json5-0.0.29.tgz#ee28707ae94e11d2b827bcbe5270bcea7f3e71ee"
   integrity sha1-7ihweulOEdK4J7y+UnC86n8+ce4=
 
+"@types/lodash@^4.14.192":
+  version "4.14.192"
+  resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.192.tgz#5790406361a2852d332d41635d927f1600811285"
+  integrity sha512-km+Vyn3BYm5ytMO13k9KTp27O75rbQ0NFw+U//g+PX7VZyjCioXaRFisqSIJRECljcTv73G3i6BpglNGHgUQ5A==
+
 "@types/minimatch@*", "@types/minimatch@^3.0.5":
   version "3.0.5"
   resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.5.tgz#1001cc5e6a3704b83c236027e77f2f58ea010f40"