Fix an unstrusted compilerPath being used without a c_cpp_properties.json. (#10440)

sean-mcmanus · web-flow · commit 93dc3737fbe8 · 2023-01-30T15:55:57.000-08:00
diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts
@@ -296,7 +296,7 @@ export class CppProperties {
         this.handleConfigurationChange();
     }
     public set CompilerDefaults(compilerDefaults: CompilerDefaults) {
-        this.defaultCompilerPath = compilerDefaults.compilerPath;
+        this.defaultCompilerPath = compilerDefaults.trustedCompilerFound ? compilerDefaults.compilerPath : null;
         this.knownCompilers = compilerDefaults.knownCompilers;
         this.defaultCStandard = compilerDefaults.cStandard;
         this.defaultCppStandard = compilerDefaults.cppStandard;

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ export class CppProperties {`
`296`	`296`	`this.handleConfigurationChange();`
`297`	`297`	`}`
`298`	`298`	`public set CompilerDefaults(compilerDefaults: CompilerDefaults) {`
`299`		`- this.defaultCompilerPath = compilerDefaults.compilerPath;`
	`299`	`+ this.defaultCompilerPath = compilerDefaults.trustedCompilerFound ? compilerDefaults.compilerPath : null;`
`300`	`300`	`this.knownCompilers = compilerDefaults.knownCompilers;`
`301`	`301`	`this.defaultCStandard = compilerDefaults.cStandard;`
`302`	`302`	`this.defaultCppStandard = compilerDefaults.cppStandard;`