Merge pull request #10603 from microsoft/seanmcm/1_14_4_release

sean-mcmanus · web-flow · commit 9f2d17d40c44 · 2023-02-27T14:03:21.000-08:00
Merge for 1.14.4
diff --git a/Build/loc/TranslationsImportExport.yml b/Build/loc/TranslationsImportExport.yml
@@ -24,6 +24,11 @@ pool:
   - ImageOverride -equals AzurePipelinesWindows2022compliant
 
 steps:
+- task: NodeTool@0
+  inputs:
+    versionSpec: '16.x'
+  displayName: 'Install Node.js'
+
 - task: CmdLine@2
   inputs:
     script: 'cd Extension && yarn install'
diff --git a/Extension/CHANGELOG.md b/Extension/CHANGELOG.md
@@ -1,5 +1,18 @@
 # C/C++ for Visual Studio Code Changelog
 
+## Version 1.14.4: February 27, 2023
+### Enhancements
+* Add `c23` and `c2x` support for clang and gcc modes. [#7471](https://github.com/microsoft/vscode-cpptools/issues/7471)
+* Filter out clang-tidy `#pragma once in main file` warnings. [#10539](https://github.com/microsoft/vscode-cpptools/issues/10539)
+
+### Bug Fixes
+* Fix `--` in args making compiler querying fail. [#10529](https://github.com/microsoft/vscode-cpptools/issues/10529)
+* Fix every .C file being opened in a compile_commands.json if it's build for C++. [#10540](https://github.com/microsoft/vscode-cpptools/issues/10540)
+* Fix `-std=c++` not being used in compile_commands.json for .C files. [#10541](https://github.com/microsoft/vscode-cpptools/issues/10541)
+* Fix a bug that could cause IntelliSense to randomly stop updating.
+* Fix some random failures that could happen during database deletion.
+* Fix some random crashes on shutdown.
+
 ## Version 1.14.3: February 14, 2023
 ### New Features
 * Add recursive macro expansion on hover. [#3579](https://github.com/microsoft/vscode-cpptools/issues/3579)
diff --git a/Extension/c_cpp_properties.schema.json b/Extension/c_cpp_properties.schema.json
@@ -36,10 +36,12 @@
                             "c99",
                             "c11",
                             "c17",
+                            "c23",
                             "gnu89",
                             "gnu99",
                             "gnu11",
                             "gnu17",
+                            "gnu23",
                             "${default}"
                         ]
                     },
diff --git a/Extension/package.json b/Extension/package.json
@@ -2,7 +2,7 @@
   "name": "cpptools",
   "displayName": "C/C++",
   "description": "C/C++ IntelliSense, debugging, and code browsing.",
-  "version": "1.14.3-main",
+  "version": "1.14.4-main",
   "publisher": "ms-vscode",
   "icon": "LanguageCCPP_color_128x.png",
   "readme": "README.md",
@@ -572,10 +572,12 @@
               "c99",
               "c11",
               "c17",
+              "c23",
               "gnu89",
               "gnu99",
               "gnu11",
-              "gnu17"
+              "gnu17",
+              "gnu23"
             ],
             "markdownDescription": "%c_cpp.configuration.default.cStandard.markdownDescription%",
             "scope": "resource"
diff --git a/Extension/src/LanguageServer/Providers/codeActionProvider.ts b/Extension/src/LanguageServer/Providers/codeActionProvider.ts
@@ -169,6 +169,9 @@ export class CodeActionProvider implements vscode.CodeActionProvider {
                 resultCodeActions.push(...docCodeActions);
                 return;
             }
+            if (command.command === 'C_Cpp.CreateDeclarationOrDefinition' && (command.arguments ?? []).length === 0) {
+                command.arguments = ['codeAction']; // We report the sender of the command
+            }
             const vscodeCodeAction: vscode.CodeAction = {
                 title: title,
                 command: command.command === "edit" ? undefined : {
diff --git a/Extension/src/LanguageServer/extension.ts b/Extension/src/LanguageServer/extension.ts
@@ -423,75 +423,25 @@ export function registerCommands(enabled: boolean): void {
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.RestartIntelliSenseForFile', enabled ? onRestartIntelliSenseForFile : onDisabledCommand));
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.GenerateDoxygenComment', enabled ? onGenerateDoxygenComment : onDisabledCommand));
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.CreateDeclarationOrDefinition', enabled ? onCreateDeclarationOrDefinition : onDisabledCommand));
-    // ---------------- Wrappers -------------
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ConfigurationSelectUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ConfigurationSelect");
-            onSelectConfiguration();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.RescanWorkspaceUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("RescanWorkspace");
-            onRescanWorkspace();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ShowIdleCodeAnalysisCommandsUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ShowIdleCodeAnalysisCommands");
-            onShowIdleCodeAnalysisCommands();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ShowActiveCodeAnalysisCommandsUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ShowActiveCodeAnalysisCommands");
-            onShowActiveCodeAnalysisCommands();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.PauseParsingUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ParsingCommands");
-            onPauseParsing();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ResumeParsingUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ParsingCommands");
-            onResumeParsing();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.CheckForCompilerUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("CheckForCompiler");
-            onCheckForCompiler();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.RestartIntelliSenseForFileUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("RestartIntelliSenseForFile");
-            onRestartIntelliSenseForFile();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ShowReferencesProgressUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ShowReferencesProgress");
-            onShowReferencesProgress();
-        }
-        : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ShowParsingCommandsUI_Telemetry', enabled ?
-        () => {
-            logForUIExperiment("ParsingCommands");
-            onShowParsingCommands();
-        }
-        : onDisabledCommand));
-    // ----------------------------------------
 }
 
-async function logForUIExperiment(command: string): Promise<void> {
+function logForUIExperiment(command: string, sender?: any): void {
     const settings: CppSettings = new CppSettings((vscode.workspace.workspaceFolders && vscode.workspace.workspaceFolders.length > 0) ? vscode.workspace.workspaceFolders[0]?.uri : undefined);
-    const isNewUI: string = ui.isNewUI.toString();
-    const isOverridden: string = (settings.experimentalFeatures ?? false).toString();
-    telemetry.logLanguageServerEvent(`experiment${command}`, { newUI: isNewUI, uiOverride: isOverridden });
+    const properties: {[key: string]: string} = {
+        newUI: ui.isNewUI.toString(),
+        uiOverride: (settings.experimentalFeatures ?? false).toString(),
+        sender: getSenderType(sender)
+    };
+    telemetry.logLanguageServerEvent(`experiment${command}`, properties);
+}
+
+function getSenderType(sender?: any): string {
+    if (util.isString(sender)) {
+        return sender;
+    } else if (util.isUri(sender)) {
+        return 'contextMenu';
+    }
+    return 'commandPalette';
 }
 
 function onDisabledCommand(): void {
@@ -506,7 +456,8 @@ function onDisabledCommand(): void {
     vscode.window.showWarningMessage(message);
 }
 
-function onRestartIntelliSenseForFile(): void {
+function onRestartIntelliSenseForFile(sender?: any): void {
+    logForUIExperiment("RestartIntelliSenseForFile", sender);
     const activeEditor: vscode.TextEditor | undefined = vscode.window.activeTextEditor;
     if (!activeEditor || !activeEditor.document || activeEditor.document.uri.scheme !== "file" ||
         (activeEditor.document.languageId !== "c" && activeEditor.document.languageId !== "cpp" && activeEditor.document.languageId !== "cuda-cpp")) {
@@ -590,7 +541,8 @@ function selectDefaultCompiler(): void {
     clients.ActiveClient.promptSelectCompiler(true);
 }
 
-function onSelectConfiguration(): void {
+function onSelectConfiguration(sender?: any): void {
+    logForUIExperiment("ConfigurationSelect", sender);
     if (!isFolderOpen()) {
         vscode.window.showInformationMessage(localize("configuration.select.first", 'Open a folder first to select a configuration.'));
     } else {
@@ -656,7 +608,8 @@ function onGoToPrevDirectiveInGroup(): void {
     client.handleGoToDirectiveInGroup(false);
 }
 
-function onCheckForCompiler(): void {
+function onCheckForCompiler(sender?: any): void {
+    logForUIExperiment("CheckForCompiler", sender);
     const client: Client = getActiveClient();
     client.handleCheckForCompiler();
 }
@@ -731,7 +684,11 @@ async function onDisableAllTypeCodeAnalysisProblems(code: string, identifiersAnd
     getActiveClient().handleDisableAllTypeCodeAnalysisProblems(code, identifiersAndUris);
 }
 
-async function onCreateDeclarationOrDefinition(): Promise<void> {
+async function onCreateDeclarationOrDefinition(sender?: any): Promise<void> {
+    const properties: { [key: string]: string } = {
+        sender: getSenderType(sender)
+    };
+    telemetry.logLanguageServerEvent('CreateDeclDefn', properties);
     getActiveClient().handleCreateDeclarationOrDefinition();
 }
 
@@ -769,11 +726,13 @@ function onToggleDimInactiveRegions(): void {
     settings.update<boolean>("dimInactiveRegions", !settings.dimInactiveRegions);
 }
 
-function onPauseParsing(): void {
+function onPauseParsing(sender?: any): void {
+    logForUIExperiment("ParsingCommands", sender);
     clients.ActiveClient.pauseParsing();
 }
 
-function onResumeParsing(): void {
+function onResumeParsing(sender?: any): void {
+    logForUIExperiment("ParsingCommands", sender);
     clients.ActiveClient.resumeParsing();
 }
 
@@ -789,19 +748,23 @@ function onCancelCodeAnalysis(): void {
     clients.ActiveClient.CancelCodeAnalysis();
 }
 
-function onShowParsingCommands(): void {
+function onShowParsingCommands(sender?: any): void {
+    logForUIExperiment("ParsingCommands", sender);
     clients.ActiveClient.handleShowParsingCommands();
 }
 
-function onShowActiveCodeAnalysisCommands(): void {
+function onShowActiveCodeAnalysisCommands(sender?: any): void {
+    logForUIExperiment("ShowActiveCodeAnalysisCommands", sender);
     clients.ActiveClient.handleShowActiveCodeAnalysisCommands();
 }
 
-function onShowIdleCodeAnalysisCommands(): void {
+function onShowIdleCodeAnalysisCommands(sender?: any): void {
+    logForUIExperiment("ShowIdleCodeAnalysisCommands", sender);
     clients.ActiveClient.handleShowIdleCodeAnalysisCommands();
 }
 
-function onShowReferencesProgress(): void {
+function onShowReferencesProgress(sender?: any): void {
+    logForUIExperiment("ShowReferencesProgress", sender);
     clients.ActiveClient.handleReferencesIcon();
 }
 
@@ -898,7 +861,8 @@ function onLogDiagnostics(): void {
     clients.ActiveClient.logDiagnostics();
 }
 
-function onRescanWorkspace(): void {
+function onRescanWorkspace(sender?: string): void {
+    logForUIExperiment("RescanWorkspace", sender);
     clients.ActiveClient.rescanFolder();
 }
 
diff --git a/Extension/src/LanguageServer/ui.ts b/Extension/src/LanguageServer/ui.ts
@@ -56,6 +56,8 @@ interface ConfigurationStatus {
     priority: ConfigurationPriority;
 }
 
+const commandArguments: string[] = ['oldUI']; // We report the sender of the command
+
 export class OldUI implements UI {
     private configStatusBarItem: vscode.StatusBarItem;
     private browseEngineStatusBarItem: vscode.StatusBarItem;
@@ -84,14 +86,22 @@ export class OldUI implements UI {
         const configTooltip: string = localize("c.cpp.configuration.tooltip", "C/C++ Configuration");
         this.configStatusBarItem = vscode.window.createStatusBarItem("c.cpp.configuration.tooltip", vscode.StatusBarAlignment.Right, 0);
         this.configStatusBarItem.name = configTooltip;
-        this.configStatusBarItem.command = "C_Cpp.ConfigurationSelectUI_Telemetry";
+        this.configStatusBarItem.command = {
+            command: "C_Cpp.ConfigurationSelect",
+            title: configTooltip,
+            arguments: commandArguments
+        };
         this.configStatusBarItem.tooltip = configTooltip;
         this.ShowConfiguration = true;
 
         this.referencesStatusBarItem = vscode.window.createStatusBarItem("c.cpp.references.statusbar", vscode.StatusBarAlignment.Right, 901);
         this.referencesStatusBarItem.name = localize("c.cpp.references.statusbar", "C/C++ References Status");
         this.referencesStatusBarItem.tooltip = "";
-        this.referencesStatusBarItem.command = "C_Cpp.ShowReferencesProgressUI_Telemetry";
+        this.referencesStatusBarItem.command = {
+            command: "C_Cpp.ShowReferencesProgress",
+            title: this.referencesStatusBarItem.name,
+            arguments: commandArguments
+        };
         this.ShowReferencesIcon = false;
 
         this.intelliSenseStatusBarItem = vscode.window.createStatusBarItem("c.cpp.intellisense.statusbar", vscode.StatusBarAlignment.Right, 903);
@@ -133,7 +143,11 @@ export class OldUI implements UI {
 
     private setIsParsingWorkspacePausable(val: boolean): void {
         if (val) {
-            this.browseEngineStatusBarItem.command = "C_Cpp.ShowParsingCommandsUI_Telemetry";
+            this.browseEngineStatusBarItem.command = {
+                command: "C_Cpp.ShowParsingCommands",
+                title: this.browseEngineStatusBarItem.name ?? '',
+                arguments: commandArguments
+            };
         } else {
             this.browseEngineStatusBarItem.command = undefined;
         }
@@ -189,7 +203,11 @@ export class OldUI implements UI {
         this.intelliSenseStatusBarItem.tooltip = (this.isUpdatingIntelliSense ? this.updatingIntelliSenseTooltip : "")
             + (twoStatus ? " | " : "")
             + (val ? this.runningCodeAnalysisTooltip : "");
-        this.intelliSenseStatusBarItem.command = val ? "C_Cpp.ShowActiveCodeAnalysisCommandsUI_Telemetry" : undefined;
+        this.intelliSenseStatusBarItem.command = val ? {
+            command: "C_Cpp.ShowActiveCodeAnalysisCommands",
+            title: this.intelliSenseStatusBarItem.name ?? '',
+            arguments: commandArguments
+        } : undefined;
     }
 
     private updateCodeAnalysisTooltip(): void {
diff --git a/Extension/src/LanguageServer/ui_new.ts b/Extension/src/LanguageServer/ui_new.ts
diff --git a/Extension/ui/settings.html b/Extension/ui/settings.html
