Fix a couple clang-tidy checks. (#10668)

* Fix a couple clang-tidy checks.
* Update changelog.

Author: sean-mcmanus

Extension/CHANGELOG.md

@@ -20,6 +20,7 @@
 * Fix 'Reset IntelliSense Database' being delayed until parsing is finished. [#10616](https://github.com/microsoft/vscode-cpptools/issues/10616)
 * Fix uncaught exception with some configuration providers. [PR #10629](https://github.com/microsoft/vscode-cpptools/pull/10629)
 * Fix bugs with the "You do not have IntelliSense configured" prompt. [#10658](https://github.com/microsoft/vscode-cpptools/issues/10658), [#10659](https://github.com/microsoft/vscode-cpptools/issues/10659)
+* Fix missing clang-tidy checks setting values. [#10667](https://github.com/microsoft/vscode-cpptools/issues/10667)
 * Fix `__GXX_RTTI` incorrectly being defined by IntelliSense with clang and `-fms-compatibility`.
 * Fix random failures when adding or removing workspace folders.
 * Reduce the likelihood of an `onWillSaveWaitUntil` timeout.

Extension/package.json

@@ -1624,6 +1624,7 @@
                 "bugprone-*",
                 "bugprone-argument-comment",
                 "bugprone-assert-side-effect",
+                "bugprone-assignment-in-if-condition",
                 "bugprone-bad-signal-to-kill-thread",
                 "bugprone-bool-pointer-implicit-conversion",
                 "bugprone-branch-clone",
@@ -1946,7 +1947,7 @@
                 "hicpp-use-nullptr",
                 "hicpp-use-override",
                 "hicpp-vararg",
-                "linuxkernel-must-check-errs",
+                "linuxkernel-must-use-errs",
                 "llvm-*",
                 "llvm-else-after-return",
                 "llvm-header-guard",
@@ -2179,6 +2180,7 @@
                 "bugprone-*",
                 "bugprone-argument-comment",
                 "bugprone-assert-side-effect",
+                "bugprone-assignment-in-if-condition",
                 "bugprone-bad-signal-to-kill-thread",
                 "bugprone-bool-pointer-implicit-conversion",
                 "bugprone-branch-clone",
@@ -2501,7 +2503,7 @@
                 "hicpp-use-nullptr",
                 "hicpp-use-override",
                 "hicpp-vararg",
-                "linuxkernel-must-check-errs",
+                "linuxkernel-must-use-errs",
                 "llvm-*",
                 "llvm-else-after-return",
                 "llvm-header-guard",