Skip to content

Commit af516b9

Browse files
authored
Seanmcm/0 22 0 changelog1 (#3101)
* Update changelog, version, and fwlinks. * Add telemetry for C/C++ Clang Command Adapter usage. * Update language-service.md.
1 parent 243f213 commit af516b9

File tree

5 files changed

+43
-28
lines changed

5 files changed

+43
-28
lines changed

.github/ISSUE_TEMPLATE/language-service.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ about: 'Issues pertaining to IntelliSense, autocomplete, code editing, etc. '
3434

3535
**Additional context**
3636
<!--
37-
*Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Starting with 0.17.3, Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "http://msdl.microsoft.com/download/symbols".*
38-
Add any other context about the problem here including log messages in your Output window ("C_Cpp.loggingLevel": "Debug" in settings.json).
37+
* Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "https://msdl.microsoft.com/download/symbols".
38+
* Add any other context about the problem here including log messages in your Output window ("C_Cpp.loggingLevel": "Debug" in settings.json).
3939
-->

Extension/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# C/C++ for Visual Studio Code Change Log
22

3+
## Version 0.22.0-insiders February 5, 2019
4+
* Fix signature help active parameter selection when parameter names are missing or subsets of each other. [#2952](https://github.com/Microsoft/vscode-cpptools/issues/2952)
5+
* Render macro hover expansions as C/C++. [#3075](https://github.com/Microsoft/vscode-cpptools/issues/3075)
6+
37
## Version 0.21.0 January 23, 2019
48
### New Features
59
* Add documentation comments for hover, completion, and signature help. [#399](https://github.com/Microsoft/vscode-cpptools/issues/399)

Extension/package-lock.json

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Extension/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "cpptools",
33
"displayName": "C/C++",
44
"description": "C/C++ IntelliSense, debugging, and code browsing.",
5-
"version": "0.21.0-master",
5+
"version": "0.22.0-master",
66
"publisher": "ms-vscode",
77
"preview": true,
88
"icon": "LanguageCCPP_color_128x.png",
@@ -1415,7 +1415,7 @@
14151415
"runtimeDependencies": [
14161416
{
14171417
"description": "C/C++ language components (Linux / x86_64)",
1418-
"url": "https://go.microsoft.com/fwlink/?linkid=2037608",
1418+
"url": "https://go.microsoft.com/fwlink/?linkid=2065016",
14191419
"platforms": [
14201420
"linux"
14211421
],
@@ -1429,7 +1429,7 @@
14291429
},
14301430
{
14311431
"description": "C/C++ language components (Linux / x86)",
1432-
"url": "https://go.microsoft.com/fwlink/?linkid=2037526",
1432+
"url": "https://go.microsoft.com/fwlink/?linkid=2065017",
14331433
"platforms": [
14341434
"linux"
14351435
],
@@ -1445,7 +1445,7 @@
14451445
},
14461446
{
14471447
"description": "C/C++ language components (OS X)",
1448-
"url": "https://go.microsoft.com/fwlink/?linkid=2037527",
1448+
"url": "https://go.microsoft.com/fwlink/?linkid=2064955",
14491449
"platforms": [
14501450
"darwin"
14511451
],
@@ -1456,7 +1456,7 @@
14561456
},
14571457
{
14581458
"description": "C/C++ language components (Windows)",
1459-
"url": "https://go.microsoft.com/fwlink/?linkid=2037609",
1459+
"url": "https://go.microsoft.com/fwlink/?linkid=2065027",
14601460
"platforms": [
14611461
"win32"
14621462
],

Extension/src/LanguageServer/extension.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { UI, getUI } from './ui';
1414
import { Client } from './client';
1515
import { ClientCollection } from './clientCollection';
1616
import { CppSettings } from './settings';
17-
import { PersistentWorkspaceState } from './persistentState';
17+
import { PersistentWorkspaceState, PersistentState } from './persistentState';
1818
import { getLanguageConfig } from './languageConfig';
1919
import { getCustomConfigProviders } from './customProviders';
2020
import { PlatformInformation } from '../platform';
@@ -108,6 +108,17 @@ function onActivationEvent(): void {
108108
function realActivation(): void {
109109
if (new CppSettings().intelliSenseEngine === "Disabled") {
110110
throw new Error("Do not activate the extension when IntelliSense is disabled.");
111+
} else {
112+
let checkForConflictingExtensions: PersistentState<boolean> = new PersistentState<boolean>("CPP." + util.packageJson.version + ".checkForConflictingExtensions", true);
113+
if (checkForConflictingExtensions.Value) {
114+
checkForConflictingExtensions.Value = false;
115+
let clangCommandAdapterActive: boolean = vscode.extensions.all.some((extension: vscode.Extension<any>, index: number, array: vscode.Extension<any>[]): boolean => {
116+
return extension.isActive && extension.id === "mitaki28.vscode-clang";
117+
});
118+
if (clangCommandAdapterActive) {
119+
telemetry.logLanguageServerEvent("conflictingExtension");
120+
}
121+
}
111122
}
112123

113124
realActivationOccurred = true;

0 commit comments

Comments
 (0)