Skip to content

Commit b4c1b9d

Browse files
add cl.exe error (#8630)
1 parent 8d09704 commit b4c1b9d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

Extension/src/LanguageServer/cppBuildTaskProvider.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -447,13 +447,12 @@ class CustomBuildTaskTerminal implements Pseudoterminal {
447447
}
448448

449449
private printBuildSummary(error: string, stdout: string, stderr: string): void {
450-
if (error || (!stdout && stderr && stderr.includes("error"))) {
450+
if (error || (!stdout && stderr && stderr.includes("error")) ||
451+
(stdout && stdout.includes("error C"))) { // cl.exe compiler errors
451452
telemetry.logLanguageServerEvent("cppBuildTaskError");
452453
this.writeEmitter.fire(localize("build.finished.with.error", "Build finished with error(s).") + this.endOfLine);
453-
} else if (!stdout && stderr) { // gcc/clang
454-
telemetry.logLanguageServerEvent("cppBuildTaskWarnings");
455-
this.writeEmitter.fire(localize("build.finished.with.warnings", "Build finished with warning(s).") + this.endOfLine);
456-
} else if (stdout && stdout.includes("warning C")) { // cl.exe, compiler warnings
454+
} else if ((!stdout && stderr) || // gcc/clang
455+
(stdout && stdout.includes("warning C"))) { // cl.exe compiler warnings
457456
telemetry.logLanguageServerEvent("cppBuildTaskWarnings");
458457
this.writeEmitter.fire(localize("build.finished.with.warnings", "Build finished with warning(s).") + this.endOfLine);
459458
} else {

0 commit comments

Comments
 (0)