Fix delay in language service activation caused by cpptools.json downloading. (#1433)

* Prevent downloadCpptoolsJsonPkg from delaying activation.
* Also, changed the default workspaceParsingPriority to "highest" and the "normal" enum to "medium".
* And updated the changelog.

Author: sean-mcmanus

Extension/CHANGELOG.md

@@ -11,7 +11,9 @@
 * Performance improvements with `browse.path` parsing, and stop showing "Parsing files" when there's no actual parsing. [#1393](https://github.com/Microsoft/vscode-cpptools/issues/1393)
 * Fix crash when settings with the wrong type are used. [#1396](https://github.com/Microsoft/vscode-cpptools/issues/1396)
 * Allow semicolons in `browse.path`. [#1415](https://github.com/Microsoft/vscode-cpptools/issues/1415)
-* Add `C_Cpp.workspaceParsingPriority` setting to avoid using 100% CPU during parsing of workspace files.
+* Fix to handle relative pathing in source file paths properly when normalizing. [#1228](https://github.com/Microsoft/vscode-cpptools/issues/1228)
+* Fix delay in language service activation caused by cpptools.json downloading. [#1429](https://github.com/Microsoft/vscode-cpptools/issues/1429)
+* Add `C_Cpp.workspaceParsingPriority` setting to enable using less than 100% CPU during parsing of workspace files.
 * Add `C_Cpp.exclusionPolicy` default to `checkFolders` to avoid expensive `files.exclude` checking on every file.
 
 ## Version 0.14.5: December 18, 2017

Extension/package.json

@@ -178,10 +178,10 @@
           "enum": [
             "highest",
             "high",
-            "normal",
+            "medium",
             "low"
           ],
-          "default": "normal",
+          "default": "highest",
           "description": "Controls whether parsing of the non-active workspace files uses sleeps to avoid using 100% CPU. The values highest/high/normal/low correspond to approximately 100/75/50/25% CPU usage.",
           "scope": "resource"
         },

Extension/src/main.ts

@@ -138,27 +138,30 @@ export function activate(context: vscode.ExtensionContext): void {
     registerTempCommand("C_Cpp.TakeSurvey");
 
     processRuntimeDependencies(() => {
-        downloadCpptoolsJsonPkg().then(() => {
-            util.readFileText(util.getExtensionFilePath("cpptools.json"))
-                .then((cpptoolsString) => {
-                    processCpptoolsJson(cpptoolsString);
-                })
-                .catch((error) => {
-                    // We already log telemetry if cpptools.json fails to download.
-                })
-                .then(() => {
-                    // Main activation code.
-                    tempCommands.forEach((command) => {
-                        command.dispose();
-                    });
-                    tempCommands = [];
-                    LanguageServer.activate(delayedCommandsToExecute);
-                    delayedCommandsToExecute.forEach((command) => {
-                        vscode.commands.executeCommand(command);
-                    });
-                    delayedCommandsToExecute.clear();
+        util.readFileText(util.getExtensionFilePath("cpptools.json"))
+            .then((cpptoolsString) => {
+                processCpptoolsJson(cpptoolsString);
+            })
+            .catch((error) => {
+                // We already log telemetry if cpptools.json fails to download.
+            })
+            .then(() => {
+                // Main activation code.
+                tempCommands.forEach((command) => {
+                    command.dispose();
                 });
-        });
+                tempCommands = [];
+                LanguageServer.activate(delayedCommandsToExecute);
+                delayedCommandsToExecute.forEach((command) => {
+                    vscode.commands.executeCommand(command);
+                });
+                delayedCommandsToExecute.clear();
+            })
+            .then(() => {
+                // Redownload cpptools.json after activation so it's not blocked.
+                // It'll be used after the extension reloads.
+                downloadCpptoolsJsonPkg();
+            });
     });
 
     setInterval(() => {