Skip to content

Commit c5e6699

Browse files
authored
Fix bug with Insider installation. (#4767)
Fix for #3874 . This was also causing my previous "downgrade" fix to fail: #4760
1 parent 297bada commit c5e6699

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Extension/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
### Bug Fixes
55
* Fix IntelliSense regression crashes. [#4754](https://github.com/microsoft/vscode-cpptools/issues/4754)
66
* Fix Insiders channel not auto-downgrading after an Insiders vsix is unpublished. [#4760](https://github.com/microsoft/vscode-cpptools/issues/4760)
7+
* Fix Insiders channel not working on remote targets. [#3874](https://github.com/microsoft/vscode-cpptools/issues/3874)
78

89
## Version 0.26.3-insiders: December 16, 2019
910
### Bug Fixes

Extension/src/LanguageServer/extension.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ function installVsix(vsixLocation: string): Thenable<void> {
633633

634634
// 1.33.0 introduces workbench.extensions.installExtension. 1.32.3 was immediately prior.
635635
let lastVersionWithoutInstallExtensionCommand: PackageVersion = new PackageVersion('1.32.3');
636-
if (userVersion.isGreaterThan(lastVersionWithoutInstallExtensionCommand)) {
636+
if (userVersion.isGreaterThan(lastVersionWithoutInstallExtensionCommand, "insider")) {
637637
return vscode.commands.executeCommand('workbench.extensions.installExtension', vscode.Uri.file(vsixLocation));
638638
}
639639

@@ -672,7 +672,7 @@ function installVsix(vsixLocation: string): Thenable<void> {
672672

673673
// 1.28.0 changes the CLI for making installations. 1.27.2 was immediately prior.
674674
let oldVersion: PackageVersion = new PackageVersion('1.27.2');
675-
if (userVersion.isGreaterThan(oldVersion)) {
675+
if (userVersion.isGreaterThan(oldVersion, "insider")) {
676676
return new Promise<void>((resolve, reject) => {
677677
let process: ChildProcess;
678678
try {

0 commit comments

Comments
 (0)