add telemetry

Author: bobbrow

Extension/src/LanguageServer/extension.ts

@@ -431,8 +431,8 @@ export async function registerCommands(enabled: boolean): Promise<void> {
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ExtractToMemberFunction', enabled ? () => onExtractToFunction(false, true) : onDisabledCommand));
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ExpandSelection', enabled ? (r: Range) => onExpandSelection(r) : onDisabledCommand));
     commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ShowCopilotHover', enabled ? () => onCopilotHover() : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.SetDevEnvironment', enabled ? () => onSetDevEnvironment() : onDisabledCommand));
-    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ClearDevEnvironment', enabled ? () => onClearDevEnvironment() : onDisabledCommand));
+    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.SetDevEnvironment', enabled ? onSetDevEnvironment : onDisabledCommand));
+    commandDisposables.push(vscode.commands.registerCommand('C_Cpp.ClearDevEnvironment', enabled ? onClearDevEnvironment : onDisabledCommand));
 }
 
 function onDisabledCommand() {
@@ -1562,14 +1562,17 @@ async function showCopilotContent(copilotHoverProvider: CopilotHoverProvider, ho
     return true;
 }
 
-async function onSetDevEnvironment(): Promise<void> {
+async function onSetDevEnvironment(sender?: any): Promise<void> {
+    let success: boolean = true;
     try {
         await setEnvironment(util.extensionContext);
         await vscode.commands.executeCommand('setContext', 'cpptools.msvcEnvironmentFound', util.hasMsvcEnvironment());
         void vscode.window.showInformationMessage(`${util.extensionContext?.environmentVariableCollection.description} successfully set.`);
     } catch (error: any) {
+        success = false;
         void vscode.window.showErrorMessage(`Developer environment not set: ${error.message}`);
     }
+    telemetry.logLanguageServerEvent("SetDevEnvironment", { "sender": util.getSenderType(sender), success: success.toString() });
 }
 
 async function onClearDevEnvironment(): Promise<void> {

Extension/walkthrough/devcommandprompt/open-developer-command-prompt.md

@@ -1,9 +1,9 @@
 <h1 data-loc-id="walkthrough.windows.title.open.dev.command.prompt">Relaunch using the <span>Developer Command Prompt for VS</span></h1>
-<p data-loc-id="walkthrough.windows.background.dev.command.prompt">You are using a Windows machine with the MSVC compiler, so for all environment variables to be set correctly, you either need to:</p>
+<p data-loc-id="walkthrough.windows.background.dev.command.prompt" data-loc-hint="This is an incomplete sentence that will be continued in the bullet points to follow">You are using a Windows machine with the MSVC compiler, so for all environment variables to be set correctly, you either need to:</p>
 <ul>
 <li><p data-loc-id="walkthrough.windows.start.from.dev.command">Start VS Code from the <span>Developer Command Prompt for VS</span>, or</p>
 </li>
-<li><p data-loc-id="walkthrough.windows.run.dev.command">Run the <code>C/C++: Set Developer Environment</code> command.</p>
+<li><p data-loc-id="walkthrough.windows.run.dev.command">Run the <code data-loc-id="walkthrough.windows.set.dev.environment">C/C++: Set Developer Environment</code> command.</p>
 </li>
 </ul>
 <h4 data-loc-id="walkthrough.windows.relaunch.command.prompt">To relaunch using the <span>Developer Command Prompt for VS</span></h4>