Remove outdated logic from getConfigIndexForPlatform (#1992)

Author: bobbrow

Extension/src/LanguageServer/configurations.ts

@@ -267,17 +267,13 @@ export class CppProperties {
     }
 
     private getConfigIndexForPlatform(config: any): number {
-        if (this.configurationJson.configurations.length > 3) {
-            return this.configurationJson.configurations.length - 1; // Default to the last custom configuration.
-        }
-        let nodePlatform: NodeJS.Platform = process.platform;
         let plat: string;
-        if (nodePlatform === 'linux') {
-            plat = "Linux";
-        } else if (nodePlatform === 'darwin') {
+        if (process.platform === 'darwin') {
             plat = "Mac";
-        } else if (nodePlatform === 'win32') {
+        } else if (process.platform === 'win32') {
             plat = "Win32";
+        } else {
+            plat = "Linux";
         }
         for (let i: number = 0; i < this.configurationJson.configurations.length; i++) {
             if (config.configurations[i].name === plat) {
@@ -293,14 +289,12 @@ export class CppProperties {
             return "clang-x64";
         } else if (name === "Win32") {
             return "msvc-x64";
-        } else {
+        } else if (process.platform === 'win32') {
             // Custom configs default to the OS's preference.
-            let nodePlatform: NodeJS.Platform = process.platform;
-            if (nodePlatform === 'linux' || nodePlatform === 'darwin') {
-                return "clang-x64";
-            }
+            return "msvc-x64";
+        } else {
+            return "clang-x64";
         }
-        return "msvc-x64";
     }
 
     private includePathConverted(): boolean {
@@ -595,7 +589,7 @@ export class CppProperties {
         for (let i: number = 0; i < this.configurationJson.configurations.length; i++) {
             let config: Configuration = this.configurationJson.configurations[i];
             // Look for Mac configs and extra configs on Mac systems
-            if (config.name === "Mac" || (process.platform === "darwin" && config.name !== "Win32" && config.name !== "Linux")) {
+            if (config.name === "Mac" || (process.platform === 'darwin' && config.name !== "Win32" && config.name !== "Linux")) {
                 if (config.macFrameworkPath === undefined) {
                     config.macFrameworkPath = [
                         "/System/Library/Frameworks",