Provide user hint through IntelliSense fallback msg that vcpkg is installed and is being used. (#1910)

Author: Jim Griesmer

Extension/cpp_snippets.json

@@ -7,7 +7,7 @@
   },
   "classi": {
     "prefix": "classi",
-    "body": "\nclass ${1:${TM_FILENAME_BASE}}\n{\nprivate:\n\t${2:/* data */}\npublic:\n\t${1}::${1}(${3:/* args */}) { $0 }\n\t${1}::~${1}() { }\n};",
+    "body": "\nclass ${1:${TM_FILENAME_BASE}}\n{\nprivate:\n\t${2:/* data */}\npublic:\n\t${1}(${3:/* args */}) { $0}\n\t~${1}() { }\n};",
     "description": "Code snippet for class with inlined constructor/destructor",
     "scope": "source.c++, source.objc++"
   },

Extension/package.json

@@ -1306,7 +1306,7 @@
     "vscode-debugadapter": "~1.24.0",
     "vscode-debugprotocol": "~1.24.0",
     "vscode-extension-telemetry": "~0.0.11",
-    "vscode-languageclient": "~3.4.5",
+    "vscode-languageclient": "3.5.1",
     "yauzl": "~2.8.0"
   },
   "runtimeDependencies": [

Extension/src/LanguageServer/client.ts

@@ -686,7 +686,10 @@ class DefaultClient implements Client {
             if (showIntelliSenseFallbackMessage.Value) {
                 let learnMorePanel: string = "Learn More";
                 let dontShowAgain: string = "Don't Show Again";
-                vscode.window.showInformationMessage("Configure includePath for better IntelliSense results.", learnMorePanel, dontShowAgain).then((value) => {
+                let fallbackMsg: string = this.configuration.VcpkgInstalled ?   
+                    "Update your IntelliSense settings or use Vcpkg to install libraries to help find missing headers." :
+                    "Configure your IntelliSense settings to help find missing headers.";
+                vscode.window.showInformationMessage(fallbackMsg, learnMorePanel, dontShowAgain).then((value) => {
                     switch (value) {
                         case learnMorePanel:
                             let uri: vscode.Uri = vscode.Uri.parse(`https://go.microsoft.com/fwlink/?linkid=864631`);

Extension/src/LanguageServer/configurations.ts

@@ -156,6 +156,10 @@ export class CppProperties {
         this.handleConfigurationChange();
     }
 
+    public get VcpkgInstalled(): boolean {
+        return this.vcpkgIncludes.length > 0;
+    }
+
     private onConfigurationsChanged(): void {
         this.configurationsChanged.fire(this.Configurations);
     }
@@ -234,28 +238,29 @@ export class CppProperties {
             // Check for vcpkg instance and include relevent paths if found.
             if (await util.checkFileExists(util.getVcpkgPathDescriptorFile())) {
                 let vcpkgRoot: string = await util.readFileText(util.getVcpkgPathDescriptorFile());
-                let vcpkgInstallPath: string = path.join(vcpkgRoot.trim(), "/installed");
-                if (await util.checkDirectoryExists(vcpkgInstallPath)) {
-                    let list: string[] = await util.readDir(vcpkgInstallPath);
-                    // For every *directory* in the list (non-recursive)
-                    list.forEach((entry) => {
-                        if (entry !== "vcpkg") {
-                            let pathToCheck: string = path.join(vcpkgInstallPath, entry);
-                            if (fs.existsSync(pathToCheck)) {
-                                let p: string = path.join(pathToCheck, "include");
-                                if (fs.existsSync(p)) {
-                                    this.vcpkgIncludes.push(p);
+                if (await util.checkDirectoryExists(vcpkgRoot)) {
+                    let vcpkgInstalledPath: string = path.join(vcpkgRoot.trim(), "/installed");
+                    let list: string[] = await util.readDir(vcpkgInstalledPath);
+                    if (list !== undefined) {
+                        // For every *directory* in the list (non-recursive). Each directory is basically a platform.
+                        list.forEach((entry) => {
+                            if (entry !== "vcpkg") {
+                                let pathToCheck: string = path.join(vcpkgInstalledPath, entry);
+                                if (fs.existsSync(pathToCheck)) {
+                                    let p: string = path.join(pathToCheck, "include");
+                                    if (fs.existsSync(p)) {
+                                        this.vcpkgIncludes.push(p);
+                                    }
                                 }
                             }
-                        }
-                    });
+                        });
+                    }
                 }
             }
         } catch (error) {} finally {
             this.vcpkgPathReady = true;
             this.handleConfigurationChange();
         }
-
     }
 
     private getConfigIndexForPlatform(config: any): number {