PR feedback

bobbrow · bobbrow · commit de8af3f70b9d · 2025-04-16T13:22:10.000-07:00
diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts
@@ -2139,7 +2139,7 @@ export class CppProperties {
                             badPath = `"${expandedPaths[0]}"`;
                         }
                         message = localize('cannot.find', "Cannot find: {0}", badPath);
-                        if (incorrectExpandedPaths.length === 1 && incorrectExpandedPaths[0].match(/".*"/) !== null) {
+                        if (incorrectExpandedPaths.some(p => p.match(/".*"/) !== null)) {
                             message += '.\n' + localize('wrapped.with.quotes', 'Do not add extra quotes around paths.');
                         }
                         newSquiggleMetrics.PathNonExistent++;

Original file line number	Diff line number	Diff line change
`@@ -2139,7 +2139,7 @@ export class CppProperties {`
`2139`	`2139`	badPath = `"${expandedPaths[0]}"`;
`2140`	`2140`	`}`
`2141`	`2141`	`message = localize('cannot.find', "Cannot find: {0}", badPath);`
`2142`		`- if (incorrectExpandedPaths.length === 1 && incorrectExpandedPaths[0].match(/".*"/) !== null) {`
	`2142`	`+ if (incorrectExpandedPaths.some(p => p.match(/".*"/) !== null)) {`
`2143`	`2143`	`message += '.\n' + localize('wrapped.with.quotes', 'Do not add extra quotes around paths.');`
`2144`	`2144`	`}`
`2145`	`2145`	`newSquiggleMetrics.PathNonExistent++;`