Added enforcement. (#11381)

mastrzyz · web-flow · commit f3e0f0bb056e · 2023-08-29T16:54:14.000-07:00
diff --git a/Extension/package.json b/Extension/package.json
@@ -6125,7 +6125,7 @@
         "code": "ts-node -T .scripts/code.ts",
         "verify": "ts-node -T .scripts/verify.ts",
         "prep": "yarn copy-walkthrough-media && yarn generate-native-strings && yarn translations-generate",
-        "lint": "eslint -c .eslintrc.js src test ui .scripts",
+        "lint": "eslint -c .eslintrc.js --report-unused-disable-directives src test ui .scripts",
         "compile": "(yarn verify prep || yarn prep) && tsc --build tsconfig.json",
         "watch": "(yarn verify prep || yarn prep )&& tsc --build tsconfig.json --watch",
         "rebuild": "yarn clean && yarn prep && yarn compile",
diff --git a/Extension/src/LanguageServer/settings.ts b/Extension/src/LanguageServer/settings.ts
@@ -4,8 +4,6 @@
  * ------------------------------------------------------------------------------------------ */
 'use strict';
 
-/* eslint-disable @typescript-eslint/no-unnecessary-boolean-literal-compare */
-
 import { execSync } from 'child_process';
 import * as editorConfig from 'editorconfig';
 import * as fs from 'fs';
diff --git a/Extension/src/SSH/commandInteractors.ts b/Extension/src/SSH/commandInteractors.ts
@@ -322,7 +322,6 @@ export class ContinueOnInteractor implements IInteractor {
         return ContinueOnInteractor.ID;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async onData(data: string, _cancelToken?: vscode.CancellationToken): Promise<IInteraction> {
         const result: IInteraction = { postAction: 'keep' };
         const pattern: string = escapeStringForRegex(this.continueOn);
diff --git a/Extension/src/Utility/Async/constructor.ts b/Extension/src/Utility/Async/constructor.ts
@@ -6,7 +6,6 @@
 import { is } from '../System/guards';
 import { ConstructorReturn, Reject, Resolve, AsyncConstructor } from '../System/types';
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 export function Async<TClass extends new (...args: ConstructorParameters<TClass>) => ConstructorReturn<TClass>>(ctor: TClass) {
     class AsyncConstructed extends Promise<TClass> {
         static class: TClass = ctor;
diff --git a/Extension/src/Utility/Async/factory.ts b/Extension/src/Utility/Async/factory.ts
@@ -3,8 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { is } from '../System/guards';
 import { Reject, Resolve } from '../System/types';
 
diff --git a/Extension/src/Utility/Async/iterators.ts b/Extension/src/Utility/Async/iterators.ts
@@ -125,7 +125,7 @@ export function accumulator<T>(...iterables: Some<T>[]): AsynchIterable<T> {
                 }
 
             }
-            // eslint-disable-next-line no-unmodified-loop-condition
+
         } while (!completeWhenEmpty);
         signal.dispose(false);
 
diff --git a/Extension/src/Utility/Eventing/dispatcher.ts b/Extension/src/Utility/Eventing/dispatcher.ts
@@ -41,7 +41,6 @@ const asyncHandlers = new Map<string, Subscriber[]>();
 const queue = new Array<Event<any, any>>();
 const current = new Set<Callback>();
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 export const DispatcherBusy = new ManualSignal<void>();
 
 /** starts the processing of the event queue. */
diff --git a/Extension/src/Utility/Eventing/interfaces.ts b/Extension/src/Utility/Eventing/interfaces.ts
@@ -3,8 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/naming-convention */
-
 export interface EventData<TInput = any | undefined> {
     readonly name: string;
     completed?: Promise<unknown>;
diff --git a/Extension/src/Utility/Process/program.ts b/Extension/src/Utility/Process/program.ts
@@ -3,7 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/naming-convention */
 import { fail } from 'assert';
 import { Factory } from '../Async/factory';
 import { lazy } from '../Async/lazy';
diff --git a/Extension/src/Utility/Process/streams.ts b/Extension/src/Utility/Process/streams.ts
@@ -180,7 +180,7 @@ export class LineIterator implements AsyncIterable<string>, AsyncIterator<string
      * Iterator next function.
      * @returns the next line, or undefined if the iterator is done.
      */
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
     async next(): Promise<IteratorResult<string>> {
         do {
             // is the current line (regardless of whether it's full or not) a match
diff --git a/Extension/src/Utility/System/finalize.ts b/Extension/src/Utility/System/finalize.ts
@@ -18,7 +18,6 @@ export function ignore<T>(fn: () => T | undefined) {
 }
 const finalized = new WeakSet();
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 export let ActiveFinalizers = Promise.resolve();
 
 /** This closes/ends/stops/destroys/disposes of an object or a Promise<object>
diff --git a/Extension/src/Utility/System/guards.ts b/Extension/src/Utility/System/guards.ts
@@ -41,7 +41,6 @@ export class is {
         return !is.nullish(instance) && !!instance[Symbol.asyncIterator];
     }
 
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     static Constructor(instance: any): instance is Constructor {
         return typeof instance === 'function' && !!instance.prototype && !Object.getOwnPropertyNames(instance).includes('arguments') && instance.toString().match(/^function.*\{ \[native code\] \}|^class/g);
     }
diff --git a/Extension/src/Utility/System/info.ts b/Extension/src/Utility/System/info.ts
@@ -74,7 +74,7 @@ interface FunctionInfo {
     isAsync: boolean;
 
     /** a bound callable function for the member (saves us from having to do it later anyway) */
-    // eslint-disable-next-line @typescript-eslint/ban-types
+
     fn: Function;
 }
 
diff --git a/Extension/src/Utility/Text/characterCodes.ts b/Extension/src/Utility/Text/characterCodes.ts
@@ -3,7 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/naming-convention */
 export const enum CharacterCodes {
     nullCharacter = 0,
     maxAsciiCharacter = 0x7F,
diff --git a/Extension/src/Utility/Text/scanner.ts b/Extension/src/Utility/Text/scanner.ts
@@ -971,7 +971,6 @@ export class Scanner implements Token {
     positionFromOffset(offset: number): Position {
         let position = { line: 0, column: 0, offset: 0 };
 
-        // eslint-disable-next-line keyword-spacing
         if (offset < 0 || offset > this.#length) {
             return { line: position.line, column: position.column };
         }
diff --git a/Extension/test/common/selectTests.ts b/Extension/test/common/selectTests.ts
@@ -2,8 +2,6 @@
  * Copyright (c) Microsoft Corporation. All Rights Reserved.
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
-/* eslint-disable no-cond-assign */
-/* eslint-disable @typescript-eslint/no-unused-vars */
 
 import { readdir } from 'fs/promises';
 import { IOptions, glob as globSync } from 'glob';
diff --git a/Extension/test/scenarios/MultirootDeadlockTest/tests/inlayhints.test.ts b/Extension/test/scenarios/MultirootDeadlockTest/tests/inlayhints.test.ts
@@ -3,7 +3,7 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
-/* eslint-disable @typescript-eslint/no-unused-vars */
+
 /* eslint-disable @typescript-eslint/triple-slash-reference */
 /// <reference path="../../../../vscode.d.ts" />
 
diff --git a/Extension/test/scenarios/SimpleCppProject/tests/languageServer.integration.test.ts b/Extension/test/scenarios/SimpleCppProject/tests/languageServer.integration.test.ts
@@ -2,7 +2,7 @@
  * Copyright (c) Microsoft Corporation. All Rights Reserved.
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
-/* eslint-disable @typescript-eslint/no-unused-vars */
+
 /* eslint-disable @typescript-eslint/triple-slash-reference */
 /// <reference path="../../../../vscode.d.ts" />
 
diff --git a/Extension/test/unit/async.test.ts b/Extension/test/unit/async.test.ts
@@ -70,7 +70,6 @@ describe('AsyncFactory', () => {
                 value.value = 200;
             };
 
-            // eslint-disable-next-line @typescript-eslint/ban-types
             return value as () => number;
         });
         const fn = await new f();
diff --git a/Extension/test/unit/commandLineParsing.test.ts b/Extension/test/unit/commandLineParsing.test.ts
@@ -3,8 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/no-unused-vars */
-
 import { deepEqual, throws } from 'assert';
 import { describe } from 'mocha';
 import { extractArgs } from '../../src/Utility/Process/commandLine';
diff --git a/Extension/test/unit/eventing.test.ts b/Extension/test/unit/eventing.test.ts
@@ -3,8 +3,6 @@
  * See 'LICENSE' in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 
-/* eslint-disable @typescript-eslint/no-unused-vars */
-
 import { ok, strictEqual } from 'assert';
 import { beforeEach, describe, it } from 'mocha';
 import { Async } from '../../src/Utility/Async/constructor';
@@ -55,7 +53,7 @@ class Something extends SomeBase {
 }
 
 // make an async constructor for the Something class
-// eslint-disable-next-line @typescript-eslint/naming-convention
+
 const AsyncSomething = Async(Something);
 
 describe('Event Emitters', () => {
diff --git a/Extension/test/unit/examples/someclass.ts b/Extension/test/unit/examples/someclass.ts
@@ -6,7 +6,6 @@
 import { Async } from '../../../src/Utility/Async/constructor';
 import { sleep } from '../../../src/Utility/Async/sleep';
 
-/* eslint-disable @typescript-eslint/naming-convention */
 export const Something = Async(class Something {
     hasBeenInitialized: boolean = false;
     constructor(public num: number) {
diff --git a/Extension/ui/settings.ts b/Extension/ui/settings.ts
@@ -385,5 +385,4 @@ class SettingsApp {
     }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export const app: SettingsApp = new SettingsApp();

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,6 @@ export class ContinueOnInteractor implements IInteractor {`
`322`	`322`	`return ContinueOnInteractor.ID;`
`323`	`323`	`}`
`324`	`324`
`325`		`- // eslint-disable-next-line @typescript-eslint/no-unused-vars`
`326`	`325`	`async onData(data: string, _cancelToken?: vscode.CancellationToken): Promise<IInteraction> {`
`327`	`326`	`const result: IInteraction = { postAction: 'keep' };`
`328`	`327`	`const pattern: string = escapeStringForRegex(this.continueOn);`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ export function accumulator<T>(...iterables: Some<T>[]): AsynchIterable<T> {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`}`
`128`		`- // eslint-disable-next-line no-unmodified-loop-condition`
	`128`	`+`
`129`	`129`	`} while (!completeWhenEmpty);`
`130`	`130`	`signal.dispose(false);`
`131`	`131`