Skip to content

Commit fc21920

Browse files
authored
Fix null reference in updateCustomBrowseConfiguration. (#5055)
* Fix null reference in updateCustomBrowseConfiguration.
1 parent d4910cc commit fc21920

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Extension/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Version 0.27.0-insiders2: March 4, 2019
44
### Bug Fixes
55
* Fix the `Open File...` scenario (without a workspace folder). [#5049](https://github.com/microsoft/vscode-cpptools/issues/5049)
6+
* Fix `browsePath` null reference that can occur with some configuration providers. [PR #5055](https://github.com/microsoft/vscode-cpptools/pull/5055)
67

78
## Version 0.27.0-insiders: March 3, 2019
89
### Enhancements

Extension/src/LanguageServer/client.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,6 +1456,9 @@ export class DefaultClient implements Client {
14561456
// Resume parsing on either resolve or reject, only if parsing was not resumed due to timeout
14571457
let hasCompleted: boolean = false;
14581458
task().then(async config => {
1459+
if (!config) {
1460+
return;
1461+
}
14591462
// TODO: This is a hack to get around CMake Tools bug: https://github.com/microsoft/vscode-cmake-tools/issues/1073
14601463
let foundMatch: boolean = false;
14611464
for (let c of config.browsePath) {

0 commit comments

Comments
 (0)