lsp ignore `"` in compile_commands.json

[codehz]

Type: LanguageService

Describe the bug

• OS and Version: ArchLinux (x64)
• VS Code Version: 1.41.1
• C/C++ Extension Version: 0.26.3-insiders2
• Other extensions you installed (and if the issue persists after disabling them):
• A clear and concise description of what the bug is.

lsp ignore " in compile_commands.json

To Reproduce
test.c:

char text[] = __sth__;

c_cpp_properties.json

{
    "configurations": [
        {
            "name": "Linux",
            "includePath": [
                "${workspaceFolder}/**"
            ],
            "compilerPath": "/usr/bin/gcc",
            "cStandard": "c11",
            "cppStandard": "c++17",
            "intelliSenseMode": "gcc-x64",
            "compileCommands": "${workspaceFolder}/compile_commands.json"
        }
    ],
    "version": 4
}

compile_commands.json:

[
    {
        "file": "test.c",
        "directory": "<your directory>",
        "arguments": [
            "/usr/bin/gcc",
            "-c",
            "-D__sth__=\"test\"",
            "test.c"
        ]
    }
]

Expected behavior

no error report

Screenshots

Additional context

正在为 /home/codehz/Projects/code/test.c 发送编译参数
  包括: /usr/include/c++/9.2.0
  包括: /usr/include/c++/9.2.0/x86_64-pc-linux-gnu
  包括: /usr/local/include
  包括: /usr/lib/clang/9.0.0/include
  包括: /usr/include
  定义: __sth__=test
  其他: --gcc
  其他: --gnu_version=80100
  stdver: c11
  intelliSenseMode: gcc-x64

[sean-mcmanus]

This appears to be "by design" according to the thread at #2305 . We expect \\\" to be used instead of \" to get the result you desire. Are you able to change the compile_command.json to use that?

[codehz]

@sean-mcmanus BUT my compile_commands is passed from JSON ARRAY insteads of single STRING
it is pointless to use \\\"

["gcc", "-D_X_=\"test\""] vs "gcc -D_X_=\\\"test\\\""

[sean-mcmanus]

Okay, looks like #2305 applies to the "command" and not the "arguments". The fix seems trivial (remove the code that erases the \").