Skip to content

Remove usage of intellisenseEngineFallback setting. #12600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Remove usage of intellisenseEngineFallback setting. #12600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5a7921
Remove usage of intellisenseEngineFallback setting.
tarikbrown-msft Aug 20, 2024
6eb8d13
Merge branch 'main' into browntarik/removeFallback
Colengms Aug 26, 2024
17f6980
Merge branch 'main' into browntarik/removeFallback
Colengms Aug 28, 2024
c4d7a8d
Merge branch 'main' into browntarik/removeFallback
sean-mcmanus Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,16 +915,6 @@
],
"scope": "resource"
},
"C_Cpp.intelliSenseEngineFallback": {
"type": "string",
"enum": [
"enabled",
"disabled"
],
"default": "disabled",
"markdownDescription": "%c_cpp.configuration.intelliSenseEngineFallback.markdownDescription%",
"scope": "resource"
},
"C_Cpp.exclusionPolicy": {
"type": "string",
"enum": [
Expand Down
1 change: 0 additions & 1 deletion Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,6 @@ export class DefaultClient implements Client {
const result: WorkspaceFolderSettingsParams = {
uri: workspaceFolderUri?.toString(),
intelliSenseEngine: settings.intelliSenseEngine,
intelliSenseEngineFallback: settings.intelliSenseEngineFallback,
autocomplete: settings.autocomplete,
autocompleteAddParentheses: settings.autocompleteAddParentheses,
errorSquiggles: settings.errorSquiggles,
Expand Down
2 changes: 0 additions & 2 deletions Extension/src/LanguageServer/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export interface Associations {
export interface WorkspaceFolderSettingsParams {
uri: string | undefined;
intelliSenseEngine: string;
intelliSenseEngineFallback: boolean;
autocomplete: string;
autocompleteAddParentheses: boolean;
errorSquiggles: string;
Expand Down Expand Up @@ -367,7 +366,6 @@ export class CppSettings extends Settings {
public get experimentalFeatures(): boolean { return this.getAsString("experimentalFeatures").toLowerCase() === "enabled"; }
public get suggestSnippets(): boolean { return this.getAsBoolean("suggestSnippets"); }
public get intelliSenseEngine(): string { return this.getAsString("intelliSenseEngine"); }
public get intelliSenseEngineFallback(): boolean { return this.getAsString("intelliSenseEngineFallback").toLowerCase() === "enabled"; }
public get intelliSenseCachePath(): string | undefined { return changeBlankStringToUndefined(this.getAsStringOrUndefined("intelliSenseCachePath")); }
public get intelliSenseCacheSize(): number { return this.getAsNumber("intelliSenseCacheSize"); }
public get intelliSenseMemoryLimit(): number { return this.getAsNumber("intelliSenseMemoryLimit"); }
Expand Down