From 0605a70c9e8119c594a7a1553d365693917cc2de Mon Sep 17 00:00:00 2001 From: Colen Garoutte-Carson Date: Fri, 17 Jan 2025 16:30:00 -0800 Subject: [PATCH] Fix issue with config requests before provider has registered --- Extension/src/LanguageServer/client.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts index 94f719e90..7a840a795 100644 --- a/Extension/src/LanguageServer/client.ts +++ b/Extension/src/LanguageServer/client.ts @@ -479,6 +479,7 @@ interface CodeAnalysisParams { interface FinishedRequestCustomConfigParams { uri: string; + isProviderRegistered: boolean; } export interface TextDocumentWillSaveParams { @@ -2102,8 +2103,9 @@ export class DefaultClient implements Client { } public async provideCustomConfiguration(docUri: vscode.Uri): Promise { + let isProviderRegistered: boolean = false; const onFinished: () => void = () => { - void this.languageClient.sendNotification(FinishedRequestCustomConfig, { uri: docUri.toString() }); + void this.languageClient.sendNotification(FinishedRequestCustomConfig, { uri: docUri.toString(), isProviderRegistered }); }; try { const providerId: string | undefined = this.configurationProvider; @@ -2114,6 +2116,7 @@ export class DefaultClient implements Client { if (!provider || !provider.isReady) { return; } + isProviderRegistered = true; const resultCode = await this.provideCustomConfigurationAsync(docUri, provider); telemetry.logLanguageServerEvent('provideCustomConfiguration', { providerId, resultCode }); } finally {