Skip to content

Fix issue with config requests before provider has registered #13167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Fix issue with config requests before provider has registered #13167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0605a70
Fix issue with config requests before provider has registered
Colengms Jan 18, 2025
02cde12
Merge branch 'main' into coleng/fix_early_custom_config_requests
Colengms Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ interface CodeAnalysisParams {

interface FinishedRequestCustomConfigParams {
uri: string;
isProviderRegistered: boolean;
}

export interface TextDocumentWillSaveParams {
Expand Down Expand Up @@ -2102,8 +2103,9 @@ export class DefaultClient implements Client {
}

public async provideCustomConfiguration(docUri: vscode.Uri): Promise<void> {
let isProviderRegistered: boolean = false;
const onFinished: () => void = () => {
void this.languageClient.sendNotification(FinishedRequestCustomConfig, { uri: docUri.toString() });
void this.languageClient.sendNotification(FinishedRequestCustomConfig, { uri: docUri.toString(), isProviderRegistered });
};
try {
const providerId: string | undefined = this.configurationProvider;
Expand All @@ -2114,6 +2116,7 @@ export class DefaultClient implements Client {
if (!provider || !provider.isReady) {
return;
}
isProviderRegistered = true;
const resultCode = await this.provideCustomConfigurationAsync(docUri, provider);
telemetry.logLanguageServerEvent('provideCustomConfiguration', { providerId, resultCode });
} finally {
Expand Down
Loading