Skip to content

Fix an undefined access when an edit is done before cpptools starts #13206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix an undefined access when an edit is done before cpptools starts #13206

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fe7e05
Fix an undefined access.
sean-mcmanus Jan 28, 2025
31139ab
Switch to await this.ready;
sean-mcmanus Jan 28, 2025
eb1d4ae
Update.
sean-mcmanus Jan 28, 2025
d3bf977
Change onDidOpenTextDocument.
sean-mcmanus Jan 28, 2025
2230254
Undo onDidOpen change.
sean-mcmanus Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,8 @@ export class DefaultClient implements Client {
public onDidChangeTextDocument(textDocumentChangeEvent: vscode.TextDocumentChangeEvent): void {
if (util.isCpp(textDocumentChangeEvent.document)) {
// If any file has changed, we need to abort the current rename operation
if (workspaceReferences.renamePending) {
if (workspaceReferences !== undefined // Occurs when a document changes before cpptools starts.
&& workspaceReferences.renamePending) {
workspaceReferences.cancelCurrentReferenceRequest(refs.CancellationSender.User);
}

Expand Down
2 changes: 1 addition & 1 deletion Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ async function onDidChangeSettings(event: vscode.ConfigurationChangeEvent): Prom
}
}

async function onDidChangeTextDocument(event: vscode.TextDocumentChangeEvent): Promise<void> {
function onDidChangeTextDocument(event: vscode.TextDocumentChangeEvent): void {
const me: Client = clients.getClientFor(event.document.uri);
me.onDidChangeTextDocument(event);
}
Expand Down