Skip to content

Fix an issue with C: treated as a relative path #13297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Fix an issue with C: treated as a relative path #13297

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
665e82e
Fix an issue with C: treated as a relative path
Colengms Feb 20, 2025
ffdfc66
Merge branch 'main' into coleng/handle_root_path
Colengms Feb 20, 2025
14ddecf
Fix lint issue
Colengms Feb 20, 2025
bdbb074
Merge branch 'main' into coleng/handle_root_path
Colengms Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Extension/src/LanguageServer/configurations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,9 +1574,11 @@
quoted = true;
result = result.slice(1, -1);
}
// On Windows, isAbsolute does not handle root paths without a slash, such as "C:"
const isWindowsRootPath: boolean = (process.platform === 'win32' && /^[a-zA-Z]:$/.test(result));

Check failure on line 1578 in Extension/src/LanguageServer/configurations.ts

View workflow job for this annotation

GitHub Actions / job / build 

Unnecessary parentheses around expression

Check failure on line 1578 in Extension/src/LanguageServer/configurations.ts

View workflow job for this annotation

GitHub Actions / job / build 

Unnecessary parentheses around expression

Check failure on line 1578 in Extension/src/LanguageServer/configurations.ts

View workflow job for this annotation

GitHub Actions / job / build 

Unnecessary parentheses around expression
// Make sure all paths result to an absolute path.
// Do not add the root path to an unresolved env variable.
if (!result.includes("env:") && !path.isAbsolute(result) && this.rootUri) {
if (!isWindowsRootPath && !result.includes("env:") && !path.isAbsolute(result) && this.rootUri) {
result = path.join(this.rootUri.fsPath, result);
}
if (quoted) {
Expand Down
Loading