Work around E2E test failure #13347
Merged
Work around E2E test failure #13347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes impacted the performance of
didChangeCppPropertieson macOS, due to needing to resolve sub-frameworks up-front. This surfaced an existing issue in the E2E tests.Issue 1: When settings are changed, that is always resulting in TWO
didChangeCppPropertiesmessages. One appears to be redundant. If the changed setting(s) would not impact the configuration, neither are actually needed. I haven't yet investigated that. I'm guessing that addressing it may require some refactoring of settings processing on the TypeScript side. That issue is not addressed by this PR.Issue 2: The inlay hints tests were changing settings 39 times without synchronizing with completed processing of those setting changes. As a result, there's a backlog of settings changes in queue as the next test starts, causing it to timeout waiting for the result of later requests.
This change works around the issue with a (large/safe) sleep as each setting change is made.
A proper fix would involve finding some way to synchronize with the setting changes being completely applied.