From 8507947faf17966b40eb1049291e99a125df6bfa Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Fri, 11 Apr 2025 15:17:40 -0700 Subject: [PATCH] Fix SIG-?? matching the filter regex. --- Extension/src/LanguageServer/extension.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Extension/src/LanguageServer/extension.ts b/Extension/src/LanguageServer/extension.ts index 53bb833c2..826c18814 100644 --- a/Extension/src/LanguageServer/extension.ts +++ b/Extension/src/LanguageServer/extension.ts @@ -1210,7 +1210,9 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr signalType = lines[crashStackStartLine] + "\n"; } else { // The signal type may fail to be written. - signalType = "SIG-??\n"; // Intentionally different from SIG-? from cpptools. + // Intentionally different from SIGUNKNOWN from cpptools, + // and not SIG-? to avoid matching the regex in containsFilteredTelemetryData. + signalType = "SIGMISSING\n"; } data = telemetryHeader + signalType; let crashCallStack: string = ""; @@ -1329,11 +1331,6 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr data += crashCallStack; - // TODO: Remove this in 1.25.1 after it's confirmed that it's not happening. - if (containsFilteredTelemetryData(data)) { - data = "unexpected call stack\n"; - } - logCppCrashTelemetry(data, addressData, crashLog); await util.deleteFile(path.resolve(crashDirectory, crashFile)).catch(logAndReturn.undefined);