From 36915ce7e61e6d6802fa3e8a593a623b58bdd3b5 Mon Sep 17 00:00:00 2001 From: Bob Brown Date: Thu, 9 Oct 2025 09:31:48 -0700 Subject: [PATCH 1/2] Fix some invalid assumptions for tasks --- Extension/src/LanguageServer/cppBuildTaskProvider.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Extension/src/LanguageServer/cppBuildTaskProvider.ts b/Extension/src/LanguageServer/cppBuildTaskProvider.ts index de08d6e43..da3db87a4 100644 --- a/Extension/src/LanguageServer/cppBuildTaskProvider.ts +++ b/Extension/src/LanguageServer/cppBuildTaskProvider.ts @@ -245,7 +245,7 @@ export class CppBuildTaskProvider implements TaskProvider { const cppBuildTask: CppBuildTask = new Task(definition, TaskScope.Workspace, task.label, ext.CppSourceStr); cppBuildTask.detail = task.detail; cppBuildTask.existing = true; - if (task.group.isDefault) { + if (!util.isString(task.group) && task.group.isDefault) { cppBuildTask.isDefault = true; } return cppBuildTask; @@ -292,9 +292,9 @@ export class CppBuildTaskProvider implements TaskProvider { if (setAsDefault) { rawTasksJson.tasks.forEach((task: any) => { if (task.label === selectedTask?.definition.label) { - task.group = { kind: "build", "isDefault": true }; - } else if (task.group.kind && task.group.kind === "build" && task.group.isDefault && task.group.isDefault === true) { - task.group = "build"; + task.group = { kind: "build", isDefault: true }; + } else if (!util.isString(task.group) && task.group?.kind === "build" && task.group?.isDefault) { + task.group.isDefault = false; } }); } From 5bd24fda4673467dcec51e7676d5e43e897e7d2e Mon Sep 17 00:00:00 2001 From: Bob Brown Date: Thu, 9 Oct 2025 09:39:41 -0700 Subject: [PATCH 2/2] one more tweak --- Extension/src/LanguageServer/cppBuildTaskProvider.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Extension/src/LanguageServer/cppBuildTaskProvider.ts b/Extension/src/LanguageServer/cppBuildTaskProvider.ts index da3db87a4..33227c14e 100644 --- a/Extension/src/LanguageServer/cppBuildTaskProvider.ts +++ b/Extension/src/LanguageServer/cppBuildTaskProvider.ts @@ -303,7 +303,7 @@ export class CppBuildTaskProvider implements TaskProvider { const newTask: any = { ...selectedTask.definition, problemMatcher: selectedTask.problemMatchers, - group: setAsDefault ? { kind: "build", "isDefault": true } : "build", + group: setAsDefault ? { kind: "build", isDefault: true } : "build", detail: localize("task.generated.by.debugger", "Task generated by Debugger.") }; rawTasksJson.tasks.push(newTask);