Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 141bd34

Browse files
authored
Merge pull request #143 from karolz-ms/dev/karolz/docker-in-docker
Update Docker-in-Docker templates
2 parents c2fe6fa + 2c5ebc5 commit 141bd34

File tree

4 files changed

+4
-30
lines changed

4 files changed

+4
-30
lines changed

containers/docker-in-docker-compose/.devcontainer/devcontainer.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@
88
// Use 'settings' to set *default* container specific settings.json values on container create.
99
// You can edit these settings after create using File > Preferences > Settings > Remote.
1010
"settings": {
11-
"terminal.integrated.shell.linux": "/bin/bash",
12-
"remote.extensionKind": {
13-
"ms-azuretools.vscode-docker": "workspace"
14-
}
11+
"terminal.integrated.shell.linux": "/bin/bash"
1512
},
1613

1714
// Uncomment the next line if you want start specific services in your Docker Compose config.

containers/docker-in-docker-compose/README.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,7 @@ You can adapt your own existing development container Docker Compose setup to su
4646
- /var/run/docker.sock:/var/run/docker.sock
4747
```
4848

49-
3. Finally, update `devcontainer.json` to force the Docker extension to be installed inside the container instead of locally. From `.devcontainer/devcontainer.json`:
50-
51-
```json
52-
"settings": {
53-
"remote.extensionKind": {
54-
"ms-azuretools.vscode-docker": "workspace"
55-
}
56-
},
57-
```
58-
59-
4. Press <kbd>F1</kbd> and run **Remote-Containers: Rebuild Container** so the changes take effect.
49+
3. Press <kbd>F1</kbd> and run **Remote-Containers: Rebuild Container** so the changes take effect.
6050

6151
That's it!
6252

containers/docker-in-docker/.devcontainer/devcontainer.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@
1616
// Use 'settings' to set *default* container specific settings.json values on container create.
1717
// You can edit these settings after create using File > Preferences > Settings > Remote.
1818
"settings": {
19-
"terminal.integrated.shell.linux": "/bin/bash",
20-
"remote.extensionKind": {
21-
"ms-azuretools.vscode-docker": "workspace"
22-
}
19+
"terminal.integrated.shell.linux": "/bin/bash"
2320
},
2421

2522
// Uncomment the next line if you want to publish any ports.

containers/docker-in-docker/README.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,7 @@ You can adapt your own existing development container Dockerfile to support this
4545
"runArgs": ["-v","/var/run/docker.sock:/var/run/docker.sock"]
4646
```
4747

48-
3. Finally, update `devcontainer.json` to force the Docker extension to be installed inside the container instead of locally. From `.devcontainer/devcontainer.json`:
49-
50-
```json
51-
"settings": {
52-
"remote.extensionKind": {
53-
"ms-azuretools.vscode-docker": "workspace"
54-
}
55-
},
56-
```
57-
58-
4. Press <kbd>F1</kbd> and run **Remote-Containers: Rebuild Container** so the changes take effect.
48+
3. Press <kbd>F1</kbd> and run **Remote-Containers: Rebuild Container** so the changes take effect.
5949

6050
That's it!
6151

0 commit comments

Comments
 (0)