Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 1c6c819

Browse files
committed
fix readme + bump netcore and MDS versions
1 parent ec297dc commit 1c6c819

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

containers/dotnet-mssql/.devcontainer/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ services:
77
dockerfile: Dockerfile
88
args:
99
# [Choice] Update 'VARIANT' to pick a .NET Core version: 2.1, 3.1, 5.0
10-
VARIANT: 3.1
10+
VARIANT: 5.0
1111
# Options
1212
INSTALL_NODE: "false"
1313
NODE_VERSION: "lts/*"

containers/dotnet-mssql/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,10 @@ This definition includes some test code that will help you verify it is working
147147
3. Start VS Code, press <kbd>F1</kbd>, and select **Remote-Containers: Open Folder in Container...**
148148
4. Select the `containers/dotnetcore` folder.
149149
5. After the folder has opened in the container, if prompted to restore packages in a notification, click "Restore".
150-
6. After packages are restored, press <kbd>F5</kbd> to start the project.
151-
7. Once the project is running, press <kbd>F1</kbd> and select **Remote-Containers: Forward Port from Container...**
152-
8. Select port 8090 and click the "Open Browser" button in the notification that appears.
153-
9. You should see "Hello remote world from ASP.NET Core!" after the page loads.
154-
10. From here, you can add breakpoints or edit the contents of the `test-project` folder to do further testing.
150+
6. After packages are restored, press <kbd>F5</kbd> to start the project. *Note: if Auto Forward Ports has been disabled, you will need to manually forward port 8090 from the container with "Remote-Containers: Forward Ports..."*
151+
7. Open the browser to [localhost:8090](http://localhost:8090).
152+
8. You should see "The databases are: ApplicationDB,msdb,model,tempdb,master" after the page loads.
153+
9. From here, you can add breakpoints or edit the contents of the `test-project` folder to do further testing.
155154

156155
## License
157156

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
2-
32
<PropertyGroup>
4-
<TargetFramework>netcoreapp3.1</TargetFramework>
3+
<TargetFramework>netcoreapp5.0</TargetFramework>
54
<UserSecretsId>31051026529000467138</UserSecretsId>
65
</PropertyGroup>
7-
86
<ItemGroup>
9-
<PackageReference Include="Microsoft.Data.SqlClient" Version="2.0.1" />
7+
<PackageReference Include="Microsoft.Data.SqlClient" Version="3.0.0" />
108
</ItemGroup>
11-
129
</Project>

0 commit comments

Comments
 (0)